From: Mark Kettenis <kettenis@gnu.org>
To: randolph@tausq.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/hppa] Several cleanups for hppa-tdep.c
Date: Wed, 10 Nov 2004 11:08:00 -0000 [thread overview]
Message-ID: <200411101107.iAAB7l0J093760@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20041110000026.GA15714@tausq.org> (message from Randolph Chung on Tue, 9 Nov 2004 16:00:26 -0800)
Date: Tue, 9 Nov 2004 16:00:26 -0800
From: Randolph Chung <randolph@tausq.org>
will commit as obvious tomorrow, unless i hear otherwise.
@@ -1653,7 +1670,8 @@ hppa_frame_cache (struct frame_info *nex
{
int reg;
char buf4[4];
- long status = deprecated_read_memory_nobpt (pc, buf4, sizeof buf4);
+ long status = safe_frame_unwind_memory (next_frame, pc, buf4,
+ sizeof buf4);
long inst = extract_unsigned_integer (buf4, sizeof buf4);
This bit is probably not right. The return value from
safe_frame_unwind_memory is the opposite of
deprecated_read_memory_nobpt.
Hmm, it doesn't seem to matter; the return value isn't used. Some
more cleanups to do ;-). You probably ought to check the return value
though.
Mark
next prev parent reply other threads:[~2004-11-10 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-10 0:00 Randolph Chung
2004-11-10 11:08 ` Mark Kettenis [this message]
2004-11-10 16:28 ` Randolph Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411101107.iAAB7l0J093760@elgar.sibelius.xs4all.nl \
--to=kettenis@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox