From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24159 invoked by alias); 10 Nov 2004 11:08:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23356 invoked from network); 10 Nov 2004 11:07:49 -0000 Received: from unknown (HELO walton.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 10 Nov 2004 11:07:49 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by walton.sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id iAAB7mc6015981; Wed, 10 Nov 2004 12:07:48 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id iAAB7let093763; Wed, 10 Nov 2004 12:07:47 +0100 (CET) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id iAAB7l0J093760; Wed, 10 Nov 2004 12:07:47 +0100 (CET) Date: Wed, 10 Nov 2004 11:08:00 -0000 Message-Id: <200411101107.iAAB7l0J093760@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: randolph@tausq.org CC: gdb-patches@sources.redhat.com In-reply-to: <20041110000026.GA15714@tausq.org> (message from Randolph Chung on Tue, 9 Nov 2004 16:00:26 -0800) Subject: Re: [patch/hppa] Several cleanups for hppa-tdep.c References: <20041110000026.GA15714@tausq.org> X-SW-Source: 2004-11/txt/msg00188.txt.bz2 Date: Tue, 9 Nov 2004 16:00:26 -0800 From: Randolph Chung will commit as obvious tomorrow, unless i hear otherwise. @@ -1653,7 +1670,8 @@ hppa_frame_cache (struct frame_info *nex { int reg; char buf4[4]; - long status = deprecated_read_memory_nobpt (pc, buf4, sizeof buf4); + long status = safe_frame_unwind_memory (next_frame, pc, buf4, + sizeof buf4); long inst = extract_unsigned_integer (buf4, sizeof buf4); This bit is probably not right. The return value from safe_frame_unwind_memory is the opposite of deprecated_read_memory_nobpt. Hmm, it doesn't seem to matter; the return value isn't used. Some more cleanups to do ;-). You probably ought to check the return value though. Mark