Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [rfa] Fix DW_CFA_restore
@ 2004-11-09 15:05 Daniel Jacobowitz
  2004-11-09 15:20 ` Mark Kettenis
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2004-11-09 15:05 UTC (permalink / raw)
  To: gdb-patches, Mark Kettenis

We weren't copying all of the initial registers to fs->initial because of a
typo.  This shows up when debugging the vsyscall DSO, since its hand-written
CFI does cover its epilogue.

OK?

-- 
Daniel Jacobowitz

2004-11-09  Daniel Jacobowitz  <dan@debian.org>

	* dwarf2-frame.c (dwarf2_frame_state_alloc_regs): Correct allocated
	size.

Index: dwarf2-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2-frame.c,v
retrieving revision 1.45
diff -u -p -r1.45 dwarf2-frame.c
--- dwarf2-frame.c	7 Nov 2004 21:16:11 -0000	1.45
+++ dwarf2-frame.c	9 Nov 2004 14:42:52 -0000
@@ -162,7 +162,7 @@ dwarf2_frame_state_alloc_regs (struct dw
 static struct dwarf2_frame_state_reg *
 dwarf2_frame_state_copy_regs (struct dwarf2_frame_state_reg_info *rs)
 {
-  size_t size = rs->num_regs * sizeof (struct dwarf2_frame_state_reg_info);
+  size_t size = rs->num_regs * sizeof (struct dwarf2_frame_state_reg);
   struct dwarf2_frame_state_reg *reg;
 
   reg = (struct dwarf2_frame_state_reg *) xmalloc (size);


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [rfa] Fix DW_CFA_restore
  2004-11-09 15:05 [rfa] Fix DW_CFA_restore Daniel Jacobowitz
@ 2004-11-09 15:20 ` Mark Kettenis
  2004-11-09 20:42   ` Daniel Jacobowitz
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2004-11-09 15:20 UTC (permalink / raw)
  To: drow; +Cc: gdb-patches

   Date: Tue, 9 Nov 2004 10:05:10 -0500
   From: Daniel Jacobowitz <drow@false.org>

   We weren't copying all of the initial registers to fs->initial because of a
   typo.  This shows up when debugging the vsyscall DSO, since its hand-written
   CFI does cover its epilogue.

   OK?

Sure.

   2004-11-09  Daniel Jacobowitz  <dan@debian.org>

	   * dwarf2-frame.c (dwarf2_frame_state_alloc_regs): Correct allocated
	   size.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [rfa] Fix DW_CFA_restore
  2004-11-09 15:20 ` Mark Kettenis
@ 2004-11-09 20:42   ` Daniel Jacobowitz
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Jacobowitz @ 2004-11-09 20:42 UTC (permalink / raw)
  To: gdb-patches

On Tue, Nov 09, 2004 at 04:20:25PM +0100, Mark Kettenis wrote:
>    Date: Tue, 9 Nov 2004 10:05:10 -0500
>    From: Daniel Jacobowitz <drow@false.org>
> 
>    We weren't copying all of the initial registers to fs->initial because of a
>    typo.  This shows up when debugging the vsyscall DSO, since its hand-written
>    CFI does cover its epilogue.
> 
>    OK?
> 
> Sure.
> 
>    2004-11-09  Daniel Jacobowitz  <dan@debian.org>
> 
> 	   * dwarf2-frame.c (dwarf2_frame_state_alloc_regs): Correct allocated
> 	   size.

Checked in for HEAD, thanks.

-- 
Daniel Jacobowitz


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-11-09 20:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-09 15:05 [rfa] Fix DW_CFA_restore Daniel Jacobowitz
2004-11-09 15:20 ` Mark Kettenis
2004-11-09 20:42   ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox