[RFA/m32r] Add gdbarch_init_osabi call

[RFA/m32r] Add gdbarch_init_osabi call

[Kei Sakamoto]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hello,

m32r-linux-tdep.c calls gdbarch_register_osabi in
_initialize_m32r_linux_tdep. But gdbarch_init_osabi is not called
anywhere.

The following patch adds gdbarch_init_osabi call to m32r_gdbarch_init
and enables functions in m32r-linux-tdep.c.

OK to commit?

2004-11-04    Kei Sakamoto  <sakamoto.kei@renesas.com>

    * Makefile.in (m32r-tdep.o): Update dependencies.
    * m32r-tdep.c (m32r_gdbarch_init): Call gdbarch_init_osabi for
      ABI-specific overrides.

[-- Attachment #2: m32r-tdep.patch --]
[-- Type: application/octet-stream, Size: 1899 bytes --]

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.653
diff -u -r1.653 Makefile.in
--- Makefile.in	1 Nov 2004 21:05:46 -0000	1.653
+++ Makefile.in	4 Nov 2004 01:06:31 -0000
@@ -2171,7 +2171,7 @@
 	$(frame_base_h) $(symtab_h) $(gdbtypes_h) $(gdbcmd_h) $(gdbcore_h) \
 	$(gdb_string_h) $(value_h) $(inferior_h) $(symfile_h) $(objfiles_h) \
 	$(language_h) $(arch_utils_h) $(regcache_h) $(trad_frame_h) \
-	$(dis_asm_h) $(gdb_assert_h) $(m32r_tdep_h)
+	$(dis_asm_h) $(gdb_assert_h) $(osabi_h) $(m32r_tdep_h)
 m68hc11-tdep.o: m68hc11-tdep.c $(defs_h) $(frame_h) $(frame_unwind_h) \
 	$(frame_base_h) $(dwarf2_frame_h) $(trad_frame_h) $(symtab_h) \
 	$(gdbtypes_h) $(gdbcmd_h) $(gdbcore_h) $(gdb_string_h) $(value_h) \
Index: m32r-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m32r-tdep.c,v
retrieving revision 1.34
diff -u -r1.34 m32r-tdep.c
--- m32r-tdep.c	4 Nov 2004 00:40:39 -0000	1.34
+++ m32r-tdep.c	4 Nov 2004 01:06:32 -0000
@@ -33,6 +33,7 @@
 #include "inferior.h"
 #include "symfile.h"
 #include "objfiles.h"
+#include "osabi.h"
 #include "language.h"
 #include "arch-utils.h"
 #include "regcache.h"
@@ -938,7 +939,6 @@
 
   set_gdbarch_frame_align (gdbarch, m32r_frame_align);
 
-  frame_unwind_append_sniffer (gdbarch, m32r_frame_sniffer);
   frame_base_set_default (gdbarch, &m32r_frame_base);
 
   /* Methods for saving / extracting a dummy frame's ID.  The ID's
@@ -951,6 +951,12 @@
 
   set_gdbarch_print_insn (gdbarch, print_insn_m32r);
 
+  /* Hook in ABI-specific overrides, if they have been registered.  */
+  gdbarch_init_osabi (info, gdbarch);
+
+  /* Hook in the default unwinders.  */
+  frame_unwind_append_sniffer (gdbarch, m32r_frame_sniffer);
+
   return gdbarch;
 }
 

Re: [RFA/m32r] Add gdbarch_init_osabi call

[Daniel Jacobowitz]

On Thu, Nov 04, 2004 at 10:21:34AM +0900, Kei Sakamoto wrote:
> Hello,
> 
> m32r-linux-tdep.c calls gdbarch_register_osabi in
> _initialize_m32r_linux_tdep. But gdbarch_init_osabi is not called
> anywhere.
> 
> The following patch adds gdbarch_init_osabi call to m32r_gdbarch_init
> and enables functions in m32r-linux-tdep.c.
> 
> OK to commit?

Yes, this is OK.  Thanks.

> 
> 2004-11-04    Kei Sakamoto  <sakamoto.kei@renesas.com>
> 
>     * Makefile.in (m32r-tdep.o): Update dependencies.
>     * m32r-tdep.c (m32r_gdbarch_init): Call gdbarch_init_osabi for
>       ABI-specific overrides.



-- 
Daniel Jacobowitz

Re: [RFA/m32r] Add gdbarch_init_osabi call

[Kei Sakamoto]

> On Thu, Nov 04, 2004 at 10:21:34AM +0900, Kei Sakamoto wrote:
> > Hello,
> > 
> > m32r-linux-tdep.c calls gdbarch_register_osabi in
> > _initialize_m32r_linux_tdep. But gdbarch_init_osabi is not called
> > anywhere.
> > 
> > The following patch adds gdbarch_init_osabi call to m32r_gdbarch_init
> > and enables functions in m32r-linux-tdep.c.
> > 
> > OK to commit?
> 
> Yes, this is OK.  Thanks.

I've checked in on mainline and 6.3. Thank you.

Kei Sakamoto