Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@gnu.org>
To: drow@false.org
Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com,
	cagney@gnu.org, roland@redhat.com
Subject: Re: [rfa] Attach vsyscall support for GNU/Linux
Date: Mon, 01 Nov 2004 20:45:00 -0000	[thread overview]
Message-ID: <200411012045.iA1KjKDg000415@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20041101161552.GA26993@nevyn.them.org> (message from Daniel Jacobowitz on Mon, 1 Nov 2004 11:15:52 -0500)

   Date: Mon, 1 Nov 2004 11:15:52 -0500
   From: Daniel Jacobowitz <drow@false.org>

   On Tue, Oct 26, 2004 at 12:12:26AM +0200, Mark Kettenis wrote:
   >    Date: Sun, 24 Oct 2004 19:16:36 -0400
   >    From: Daniel Jacobowitz <drow@false.org>
   > 
   > Thanks for the explanation Daniel!
   > 
   >    Unwinding bugs aside, I think it's valuable for GDB to know that it is
   >    at a signal trampoline.  I think the custom display in backtrace is
   >    valuable.  That means we should look for signal handlers before looking
   >    for CFI.  For NPTL that value judgement would fall the other way - not
   >    having to special-case signal handlers is a clear win.
   > 
   > Given the fact that it is desirable for GDB to know that it's dealing
   > with a signal handler, I think the correct approach is to extend the
   > DWARF2 unwinder with a method to get the frame type, similar to what
   > we already do for pre-initializing the register state.
   > 
   > I'll see if I can come up with a patch for you to test.

   Had any time for this, Mark?  If not, I can try it.

I forgot about it :-(.  I had a look just now, but unfortunately it's
not as easy as I thought.  The frame type is currently hard-coded in
the unwinder.  This is wrong, but Andrew thinks it's wrong in a
different way than I.  At least, that's what I think.  I'll have to
learn reading UML diagrams first.  I'll throw some Feynman diagrams
into my next mail to get even with him ;-).  This is not going to be a
simple fix, therefore...

   I think this patch is very important for 6.3.

...you might want to convince Andrew to include your origional patch
in 6.3.  Or better yet, a patch that prepends a signal frame unwinder
only for Linux.  If you succeed, you have my blessing to check this in
on mainline too, provided you add a big fat warning why this is done
and that it's so wrong.

Sorry,

Mark


  reply	other threads:[~2004-11-01 20:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-24 18:53 Daniel Jacobowitz
2004-10-24 20:55 ` Mark Kettenis
2004-10-24 23:16   ` Daniel Jacobowitz
2004-10-25 22:12     ` Mark Kettenis
2004-10-25 22:46       ` Andrew Cagney
2004-11-01 22:13         ` Mark Kettenis
2004-11-02 14:28           ` Andrew Cagney
2004-11-01 16:15       ` Daniel Jacobowitz
2004-11-01 20:45         ` Mark Kettenis [this message]
2004-11-01 22:32           ` Daniel Jacobowitz
2004-11-02 14:29             ` Andrew Cagney
2004-11-07 21:35               ` Daniel Jacobowitz
2004-11-08 16:40                 ` Andrew Cagney
2004-11-05 23:42           ` Daniel Jacobowitz
2004-11-07 17:36             ` Mark Kettenis
2004-11-07 21:18               ` Daniel Jacobowitz
2004-11-07 21:34                 ` Mark Kettenis
2004-10-25 22:54     ` Andrew Cagney
2004-10-26  2:51     ` Roland McGrath
2004-10-26  8:17       ` Jakub Jelinek
2004-10-26 13:27         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200411012045.iA1KjKDg000415@elgar.sibelius.xs4all.nl \
    --to=kettenis@gnu.org \
    --cc=cagney@gnu.org \
    --cc=drow@false.org \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox