From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/testsuite] Stop sharing .c file between 2 testcases
Date: Fri, 29 Oct 2004 17:02:00 -0000 [thread overview]
Message-ID: <20041029170240.GQ27334@gnat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
I just read in one thread that we don't want to share .c files between
testcases. This reminded me of a testcase I recently added which did
use the .c file from another testcase... This patch should fix it.
2004-10-29 Joel Brobecker <brobecker@gnat.com>
* gdb.threads/bp_in_thread.c: New file, copied from
pthread_cond_wait.c.
* gdb.threads/bp_in_thread.c: Use bp_in_thread.c as the source
file, rather than using the .c file of another testcase.
Tested on x86-linux. Ok to apply?
--
Joel
[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 521 bytes --]
Index: bp_in_thread.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/bp_in_thread.exp,v
retrieving revision 1.2
diff -u -p -r1.2 bp_in_thread.exp
--- bp_in_thread.exp 11 Oct 2004 12:22:33 -0000 1.2
+++ bp_in_thread.exp 29 Oct 2004 17:02:12 -0000
@@ -23,7 +23,7 @@ if $tracelevel then {
strace $tracelevel
}
-set testfile "pthread_cond_wait"
+set testfile "bp_in_thread"
set srcfile ${testfile}.c
set binfile ${objdir}/${subdir}/${testfile}
[-- Attachment #3: bp_in_thread.c --]
[-- Type: text/plain, Size: 1712 bytes --]
/* A small multi-threaded test case.
Copyright 2004
Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */
#include <pthread.h>
#include <stdio.h>
#include <time.h>
void
cond_wait (pthread_cond_t *cond, pthread_mutex_t *mut)
{
pthread_mutex_lock(mut);
pthread_cond_wait (cond, mut);
pthread_mutex_unlock (mut);
}
void
noreturn (void)
{
pthread_mutex_t mut;
pthread_cond_t cond;
pthread_mutex_init (&mut, NULL);
pthread_cond_init (&cond, NULL);
/* Wait for a condition that will never be signaled, so we effectively
block the thread here. */
cond_wait (&cond, &mut);
}
void *
forever_pthread (void *unused)
{
noreturn ();
}
void
break_me (void)
{
/* Just an anchor to help putting a breakpoint. */
}
int
main (void)
{
pthread_t forever;
const struct timespec ts = { 0, 10000000 }; /* 0.01 sec */
pthread_create (&forever, NULL, forever_pthread, NULL);
for (;;)
{
nanosleep (&ts, NULL);
break_me();
}
return 0;
}
next reply other threads:[~2004-10-29 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 17:02 Joel Brobecker [this message]
2004-10-29 19:43 ` Andrew Cagney
2004-10-29 21:35 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041029170240.GQ27334@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox