From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30136 invoked by alias); 29 Oct 2004 17:02:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30089 invoked from network); 29 Oct 2004 17:02:41 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org with SMTP; 29 Oct 2004 17:02:41 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 54DD847D9C; Fri, 29 Oct 2004 10:02:40 -0700 (PDT) Date: Fri, 29 Oct 2004 17:02:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [RFA/testsuite] Stop sharing .c file between 2 testcases Message-ID: <20041029170240.GQ27334@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="mP3DRpeJDSE+ciuQ" Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2004-10/txt/msg00480.txt.bz2 --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 528 I just read in one thread that we don't want to share .c files between testcases. This reminded me of a testcase I recently added which did use the .c file from another testcase... This patch should fix it. 2004-10-29 Joel Brobecker * gdb.threads/bp_in_thread.c: New file, copied from pthread_cond_wait.c. * gdb.threads/bp_in_thread.c: Use bp_in_thread.c as the source file, rather than using the .c file of another testcase. Tested on x86-linux. Ok to apply? -- Joel --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=diff Content-length: 521 Index: bp_in_thread.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/bp_in_thread.exp,v retrieving revision 1.2 diff -u -p -r1.2 bp_in_thread.exp --- bp_in_thread.exp 11 Oct 2004 12:22:33 -0000 1.2 +++ bp_in_thread.exp 29 Oct 2004 17:02:12 -0000 @@ -23,7 +23,7 @@ if $tracelevel then { strace $tracelevel } -set testfile "pthread_cond_wait" +set testfile "bp_in_thread" set srcfile ${testfile}.c set binfile ${objdir}/${subdir}/${testfile} --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="bp_in_thread.c" Content-length: 1712 /* A small multi-threaded test case. Copyright 2004 Free Software Foundation, Inc. This file is part of GDB. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include #include #include void cond_wait (pthread_cond_t *cond, pthread_mutex_t *mut) { pthread_mutex_lock(mut); pthread_cond_wait (cond, mut); pthread_mutex_unlock (mut); } void noreturn (void) { pthread_mutex_t mut; pthread_cond_t cond; pthread_mutex_init (&mut, NULL); pthread_cond_init (&cond, NULL); /* Wait for a condition that will never be signaled, so we effectively block the thread here. */ cond_wait (&cond, &mut); } void * forever_pthread (void *unused) { noreturn (); } void break_me (void) { /* Just an anchor to help putting a breakpoint. */ } int main (void) { pthread_t forever; const struct timespec ts = { 0, 10000000 }; /* 0.01 sec */ pthread_create (&forever, NULL, forever_pthread, NULL); for (;;) { nanosleep (&ts, NULL); break_me(); } return 0; } --mP3DRpeJDSE+ciuQ--