[RFA/dwarf2] Set language to Ada for Ada compilation units

[RFA/dwarf2] Set language to Ada for Ada compilation units

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Hello,

  Re: http://sources.redhat.com/ml/gdb/2004-10/msg00208.html

This patch is almost obvious: Set the appropriate language when
processing an Ada CU. I didn't notice this because I used to use
an older compiler that still used stabs as the default debugging
format (we use the source filename extension in this case).

2004-10-07  Joel Brobecker  <brobecker@gnat.com>

        * dwarf2read.c (set_cu_language): Set language to Ada for
        DW_LANG_Ada83 and DW_LANG_Ada95.

Tested on x86-linux, with GNAT (with a gcc-34 backend). Fixes
gdb.ada: null_record.exp: ptype on null record.

OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: dwarf2read.c.diff --]
[-- Type: text/plain, Size: 540 bytes --]

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.163
diff -u -p -r1.163 dwarf2read.c
--- dwarf2read.c	21 Sep 2004 15:04:41 -0000	1.163
+++ dwarf2read.c	7 Oct 2004 14:24:29 -0000
@@ -5932,6 +5932,8 @@ set_cu_language (unsigned int lang, stru
       break;
     case DW_LANG_Ada83:
     case DW_LANG_Ada95:
+      cu->language = language_ada;
+      break;
     case DW_LANG_Cobol74:
     case DW_LANG_Cobol85:
     case DW_LANG_Pascal83:

Re: [RFA/dwarf2] Set language to Ada for Ada compilation units

[Joel Brobecker]

Ping?

Thank you,

On Thu, Oct 07, 2004 at 11:01:00PM -0700, Joel Brobecker wrote:
> Hello,
> 
>   Re: http://sources.redhat.com/ml/gdb/2004-10/msg00208.html
> 
> This patch is almost obvious: Set the appropriate language when
> processing an Ada CU. I didn't notice this because I used to use
> an older compiler that still used stabs as the default debugging
> format (we use the source filename extension in this case).
> 
> 2004-10-07  Joel Brobecker  <brobecker@gnat.com>
> 
>         * dwarf2read.c (set_cu_language): Set language to Ada for
>         DW_LANG_Ada83 and DW_LANG_Ada95.
> 
> Tested on x86-linux, with GNAT (with a gcc-34 backend). Fixes
> gdb.ada: null_record.exp: ptype on null record.
> 
> OK to apply?
> 
> Thanks,
> -- 
> Joel

> Index: dwarf2read.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/dwarf2read.c,v
> retrieving revision 1.163
> diff -u -p -r1.163 dwarf2read.c
> --- dwarf2read.c	21 Sep 2004 15:04:41 -0000	1.163
> +++ dwarf2read.c	7 Oct 2004 14:24:29 -0000
> @@ -5932,6 +5932,8 @@ set_cu_language (unsigned int lang, stru
>        break;
>      case DW_LANG_Ada83:
>      case DW_LANG_Ada95:
> +      cu->language = language_ada;
> +      break;
>      case DW_LANG_Cobol74:
>      case DW_LANG_Cobol85:
>      case DW_LANG_Pascal83:


-- 
Joel

Re: [RFA/dwarf2] Set language to Ada for Ada compilation units

[Mark Kettenis]

   Date: Fri, 15 Oct 2004 07:53:51 -0700
   From: Joel Brobecker <brobecker@gnat.com>

   Ping?

   Thank you,

   On Thu, Oct 07, 2004 at 11:01:00PM -0700, Joel Brobecker wrote:

   > This patch is almost obvious:

Obvious enough for me to step in.

   > 2004-10-07  Joel Brobecker  <brobecker@gnat.com>
   > 
   >         * dwarf2read.c (set_cu_language): Set language to Ada for
   >         DW_LANG_Ada83 and DW_LANG_Ada95.
   > 

OK.

Mark

Re: [RFA/dwarf2] Set language to Ada for Ada compilation units

[Joel Brobecker]

>    > 2004-10-07  Joel Brobecker  <brobecker@gnat.com>
>    > 
>    >         * dwarf2read.c (set_cu_language): Set language to Ada for
>    >         DW_LANG_Ada83 and DW_LANG_Ada95.
>    > 
> 
> OK.

Thanks! Checked in.

-- 
Joel