From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Change gdbarch_return_value to take function type instead of return value type
Date: Tue, 12 Oct 2004 22:15:00 -0000 [thread overview]
Message-ID: <200410122215.i9CMFcfN003173@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20041012124916.GZ6702@cygbert.vinschen.de> (message from Corinna Vinschen on Tue, 12 Oct 2004 14:49:16 +0200)
Date: Tue, 12 Oct 2004 14:49:16 +0200
From: Corinna Vinschen <vinschen@redhat.com>
Hi Corinna,
The patch looks OK to me.
There's also an important change necessary to sparc-tdep.c. sparc32 is the
only platform which calls using_struct_return from push_dummy_code. Since
push_dummy_code only has the return value type, it can neither call
using_struct_return nor gdbarch_return_value. I've created a new static
function called "sparc32_using_struct_return" which only evaluates whether
a struct return condition exists or not. The function is now used in
sparc32_push_dummy_code as well as in sparc32_return_value.
I think that for HP-UX, push_dummy_call needs to get passed the
function as a `struct value'. That could clean up things a bit
further. However, that's not for you to worry about. So please check
this in.
Mark
next prev parent reply other threads:[~2004-10-12 22:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-12 12:48 Corinna Vinschen
2004-10-12 21:09 ` Eli Zaretskii
2004-10-13 9:20 ` Corinna Vinschen
2004-10-12 22:15 ` Mark Kettenis [this message]
2004-10-13 9:30 ` Corinna Vinschen
2004-10-13 10:14 ` Corinna Vinschen
2004-10-15 14:17 ` Corinna Vinschen
2004-10-15 14:23 ` Corinna Vinschen
2004-10-19 13:29 ` Corinna Vinschen
2004-10-25 23:18 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410122215.i9CMFcfN003173@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox