From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32547 invoked by alias); 12 Oct 2004 22:15:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32496 invoked from network); 12 Oct 2004 22:15:39 -0000 Received: from unknown (HELO walton.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 12 Oct 2004 22:15:39 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by walton.sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id i9CMFd8s001072 for ; Wed, 13 Oct 2004 00:15:39 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id i9CMFcj7003176 for ; Wed, 13 Oct 2004 00:15:38 +0200 (CEST) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id i9CMFcfN003173; Wed, 13 Oct 2004 00:15:38 +0200 (CEST) Date: Tue, 12 Oct 2004 22:15:00 -0000 Message-Id: <200410122215.i9CMFcfN003173@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: gdb-patches@sources.redhat.com In-reply-to: <20041012124916.GZ6702@cygbert.vinschen.de> (message from Corinna Vinschen on Tue, 12 Oct 2004 14:49:16 +0200) Subject: Re: [RFA] Change gdbarch_return_value to take function type instead of return value type References: <20041012124916.GZ6702@cygbert.vinschen.de> X-SW-Source: 2004-10/txt/msg00220.txt.bz2 Date: Tue, 12 Oct 2004 14:49:16 +0200 From: Corinna Vinschen Hi Corinna, The patch looks OK to me. There's also an important change necessary to sparc-tdep.c. sparc32 is the only platform which calls using_struct_return from push_dummy_code. Since push_dummy_code only has the return value type, it can neither call using_struct_return nor gdbarch_return_value. I've created a new static function called "sparc32_using_struct_return" which only evaluates whether a struct return condition exists or not. The function is now used in sparc32_push_dummy_code as well as in sparc32_return_value. I think that for HP-UX, push_dummy_call needs to get passed the function as a `struct value'. That could clean up things a bit further. However, that's not for you to worry about. So please check this in. Mark