[COMMIT] Fix procfs_xfer_partial

[COMMIT] Fix procfs_xfer_partial

[Mark Kettenis]

Now where did we see this bug before...

Anyway, now sparc-sun-solaris2.9 works again.

Mark


Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.6440
diff -u -p -r1.6440 ChangeLog
--- ChangeLog	5 Oct 2004 04:07:03 -0000	1.6440
+++ ChangeLog	5 Oct 2004 11:21:01 -0000
@@ -1,3 +1,8 @@
+2004-10-05  Mark Kettenis  <kettenis@jive.nl>
+
+	* procfs.c (procfs_xfer_partial): Use WRITEBUF instead of READBUF
+	when writing to memory.
+
 2004-10-05  Kei Sakamoto  <sakamoto.kei@renesas.com>
 
 	* m32r-tdep.c (m32r_use_struct_convention): Delete function.
Index: procfs.c
===================================================================
RCS file: /cvs/src/src/gdb/procfs.c,v
retrieving revision 1.58
diff -u -p -r1.58 procfs.c
--- procfs.c	27 Aug 2004 13:37:42 -0000	1.58
+++ procfs.c	5 Oct 2004 11:21:01 -0000
@@ -4329,7 +4329,7 @@ procfs_xfer_partial (struct target_ops *
 	return (*ops->to_xfer_memory) (offset, readbuf, len, 0/*write*/,
 				       NULL, ops);
       if (writebuf)
-	return (*ops->to_xfer_memory) (offset, readbuf, len, 1/*write*/,
+	return (*ops->to_xfer_memory) (offset, writebuf, len, 1/*write*/,
 				       NULL, ops);
       return -1;
 

Re: [COMMIT] Fix procfs_xfer_partial

[Andrew Cagney]

> -	return (*ops->to_xfer_memory) (offset, readbuf, len, 1/*write*/,
> +	return (*ops->to_xfer_memory) (offset, writebuf, len, 1/*write*/,
>  				       NULL, ops);

You'll need to cast away the constantness of writebuf.  Something 
detected with -Werror ;-)

Andrew

Re: [COMMIT] Fix procfs_xfer_partial

[Mark Kettenis]

   Date: Tue, 05 Oct 2004 09:18:27 -0400
   From: Andrew Cagney <cagney@gnu.org>

   > -	return (*ops->to_xfer_memory) (offset, readbuf, len, 1/*write*/,
   > +	return (*ops->to_xfer_memory) (offset, writebuf, len, 1/*write*/,
   >  				       NULL, ops);

   You'll need to cast away the constantness of writebuf.  Something 
   detected with -Werror ;-)

Darn.  Not with gcc-3.2.3.  I'll try to fix this over the weekend
(I've been away from home for a few days).

Mark