From: Daniel Jacobowitz <drow@false.org>
To: Michael Chastain <mec.gnu@mindspring.com>
Cc: kettenis@chello.nl, gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFA] Testsuite improvements for non-decr_pc_after_break i386
Date: Mon, 16 Aug 2004 01:18:00 -0000 [thread overview]
Message-ID: <20040816011842.GA7780@nevyn.them.org> (raw)
In-Reply-To: <411F0AEA.nail9Q211HV3N@mindspring.com>
On Sun, Aug 15, 2004 at 03:04:10AM -0400, Michael Chastain wrote:
> This patch is approved.
>
> I proofread it. I also tested it on native i686-pc-linux-gnu,
> which is a no-adjust platform ($eip points after the breakpoint).
> I turned it into an adjust platform with this:
>
> gdb_test "set \$pc = \$pc - 1" "" "decr pc"
>
> ... and the logic works.
FYI, you've got the nomenclature backwards - adjust-pc-after-break
means "GDB must adjust the PC after break to figure out where the
breakpoint was".
--
Daniel Jacobowitz
next prev parent reply other threads:[~2004-08-16 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 20:06 Mark Kettenis
2004-08-15 7:04 ` Michael Chastain
2004-08-16 1:18 ` Daniel Jacobowitz [this message]
2004-08-16 9:43 ` Michael Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040816011842.GA7780@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox