From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13043 invoked by alias); 16 Aug 2004 01:18:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13036 invoked from network); 16 Aug 2004 01:18:44 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 16 Aug 2004 01:18:44 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BwW95-00022N-18; Sun, 15 Aug 2004 21:18:43 -0400 Date: Mon, 16 Aug 2004 01:18:00 -0000 From: Daniel Jacobowitz To: Michael Chastain Cc: kettenis@chello.nl, gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Testsuite improvements for non-decr_pc_after_break i386 Message-ID: <20040816011842.GA7780@nevyn.them.org> Mail-Followup-To: Michael Chastain , kettenis@chello.nl, gdb-patches@sources.redhat.com References: <200408142006.i7EK6bEE001195@elgar.kettenis.dyndns.org> <411F0AEA.nail9Q211HV3N@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <411F0AEA.nail9Q211HV3N@mindspring.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-08/txt/msg00531.txt.bz2 On Sun, Aug 15, 2004 at 03:04:10AM -0400, Michael Chastain wrote: > This patch is approved. > > I proofread it. I also tested it on native i686-pc-linux-gnu, > which is a no-adjust platform ($eip points after the breakpoint). > I turned it into an adjust platform with this: > > gdb_test "set \$pc = \$pc - 1" "" "decr pc" > > ... and the logic works. FYI, you've got the nomenclature backwards - adjust-pc-after-break means "GDB must adjust the PC after break to figure out where the breakpoint was". -- Daniel Jacobowitz