From: Mark Kettenis <kettenis@chello.nl>
To: rmh@debian.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] i386bsd-nat.c tweak
Date: Thu, 12 Aug 2004 08:55:00 -0000 [thread overview]
Message-ID: <200408120855.i7C8tN57065199@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20040809224424.GB18914@khazad.dyndns.org> (message from Robert Millan on Tue, 10 Aug 2004 00:44:24 +0200)
Date: Tue, 10 Aug 2004 00:44:24 +0200
From: Robert Millan <rmh@debian.org>
On Mon, Aug 09, 2004 at 10:48:25PM +0200, Mark Kettenis wrote:
> diff -u -p -r1.29 i386bsd-nat.c
> --- i386bsd-nat.c 31 May 2004 11:20:41 -0000 1.29
> +++ i386bsd-nat.c 9 Aug 2004 20:31:18 -0000
> @@ -357,10 +357,10 @@ _initialize_i386bsd_nat (void)
> #define SC_REG_OFFSET i386nbsd_sc_reg_offset
> #elif defined (OpenBSD)
> #define SC_REG_OFFSET i386obsd_sc_reg_offset
> -#else
> -#define SC_REG_OFFSET i386bsd_sc_reg_offset
> #endif
This disables the code below on GNU/kFreeBSD, but it's still enabled in
FreeBSD 4.x or later.
Yes indeed.
Our sigcontext structure is like FreeBSD's (the code is borrowed from
machine/signal.h). My impression is that on GNU/kFreeBSD we want to define
SC_REG_OFFSET i386fbsd4_sc_reg_offset. Please let me know if I'm missing
something.
Your sigcontext structure better be identical to FreeBSD's since its
part of the kernel ABI.
Build on GNU/kFreeBSD still works, but it might be that keeping
SC_REG_OFFSET undefined results in a weird runtime bug that will be
difficult to trace, so I'd really like to be sure this part is ok.
It will be caught on normal FreeBSD.
Mark
next prev parent reply other threads:[~2004-08-12 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 20:48 Mark Kettenis
2004-08-09 22:44 ` Robert Millan
2004-08-12 8:55 ` Mark Kettenis [this message]
2004-08-12 9:39 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408120855.i7C8tN57065199@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=rmh@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox