From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18370 invoked by alias); 12 Aug 2004 08:55:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18098 invoked from network); 12 Aug 2004 08:55:27 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 12 Aug 2004 08:55:27 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i7C8tOZt006080; Thu, 12 Aug 2004 10:55:24 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i7C8tOmT065202; Thu, 12 Aug 2004 10:55:24 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i7C8tN57065199; Thu, 12 Aug 2004 10:55:23 +0200 (CEST) Date: Thu, 12 Aug 2004 08:55:00 -0000 Message-Id: <200408120855.i7C8tN57065199@elgar.kettenis.dyndns.org> From: Mark Kettenis To: rmh@debian.org CC: gdb-patches@sources.redhat.com In-reply-to: <20040809224424.GB18914@khazad.dyndns.org> (message from Robert Millan on Tue, 10 Aug 2004 00:44:24 +0200) Subject: Re: [PATCH] i386bsd-nat.c tweak References: <200408092048.i79KmP7c058727@elgar.kettenis.dyndns.org> <20040809224424.GB18914@khazad.dyndns.org> X-SW-Source: 2004-08/txt/msg00442.txt.bz2 Date: Tue, 10 Aug 2004 00:44:24 +0200 From: Robert Millan On Mon, Aug 09, 2004 at 10:48:25PM +0200, Mark Kettenis wrote: > diff -u -p -r1.29 i386bsd-nat.c > --- i386bsd-nat.c 31 May 2004 11:20:41 -0000 1.29 > +++ i386bsd-nat.c 9 Aug 2004 20:31:18 -0000 > @@ -357,10 +357,10 @@ _initialize_i386bsd_nat (void) > #define SC_REG_OFFSET i386nbsd_sc_reg_offset > #elif defined (OpenBSD) > #define SC_REG_OFFSET i386obsd_sc_reg_offset > -#else > -#define SC_REG_OFFSET i386bsd_sc_reg_offset > #endif This disables the code below on GNU/kFreeBSD, but it's still enabled in FreeBSD 4.x or later. Yes indeed. Our sigcontext structure is like FreeBSD's (the code is borrowed from machine/signal.h). My impression is that on GNU/kFreeBSD we want to define SC_REG_OFFSET i386fbsd4_sc_reg_offset. Please let me know if I'm missing something. Your sigcontext structure better be identical to FreeBSD's since its part of the kernel ABI. Build on GNU/kFreeBSD still works, but it might be that keeping SC_REG_OFFSET undefined results in a weird runtime bug that will be difficult to trace, so I'd really like to be sure this part is ok. It will be caught on normal FreeBSD. Mark