From: Mark Kettenis <kettenis@chello.nl>
To: mec.gnu@mindspring.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/testsuite] lib/gdb.exp: native tcl gdb_get_line_number
Date: Mon, 09 Aug 2004 20:22:00 -0000 [thread overview]
Message-ID: <200408092022.i79KMQwm057980@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <4117D4E9.nailNML1MZER2@mindspring.com> (message from Michael Chastain on Mon, 09 Aug 2004 15:47:53 -0400)
Date: Mon, 09 Aug 2004 15:47:53 -0400
From: Michael Chastain <mec.gnu@mindspring.com>
> The attached patch fixes things for me, but can somebody please check
> whether i've escaped the dot correctly?
I'm going to think about this problem a bit. I don't really like that
compatibility kludge in the first place, and I'd rather bust some heads
in the callers and de-kludge this rather then en-kludge it some more.
So this patch is not approved. (If I don't get the problem fixed pretty
quick then I'll have to accept it though).
OK.
Which files are causing problems on your system? On my system,
the intersection between gdb_get_line_number and ${srcfile*} with
a "/" in them is:
gdb.cp/ctti.exp
gdb.cp/m-static.exp
So I would have to change two callers.
Looks like you're right. Here's a diff of the testsuite resuults:
--- ../testresults/20040808/gdb.sum Mon Aug 9 22:05:51 2004
+++ gdb/testsuite/gdb.sum Mon Aug 9 22:13:51 2004
@@ -1,4 +1,4 @@
-Test Run By kettenis on Mon Aug 9 22:00:30 2004
+Test Run By kettenis on Mon Aug 9 22:09:33 2004
Native configuration is i386-unknown-freebsd4.7
=== gdb tests ===
@@ -7027,10 +7026,11 @@
PASS: gdb.cp/cplusfuncs.exp: info function for "operator()("
PASS: gdb.cp/cplusfuncs.exp: info function for "operator char \*("
Running ../../../src/gdb/testsuite/gdb.cp/ctti.exp ...
-PASS: gdb.cp/ctti.exp: continue to breakpoint: marker add1
-PASS: gdb.cp/ctti.exp: print c
-PASS: gdb.cp/ctti.exp: print f
-PASS: gdb.cp/ctti.exp: print i
+ERROR: couldn't open "../../../src/gdb/testsuite/gdb.cp/../../../src/gdb/testsuite/gdb.cp/cttiadd.cc": no such file or directory
+UNRESOLVED: gdb.cp/ctti.exp: continue to breakpoint: marker add1
+FAIL: gdb.cp/ctti.exp: print c
+FAIL: gdb.cp/ctti.exp: print f
+FAIL: gdb.cp/ctti.exp: print i
Running ../../../src/gdb/testsuite/gdb.cp/demangle.exp ...
PASS: gdb.cp/demangle.exp: lucid: set demangle-style
PASS: gdb.cp/demangle.exp: lucid: check demangling style
@@ -8104,23 +8104,24 @@
PASS: gdb.cp/m-data.exp: shadowing member
PASS: gdb.cp/m-data.exp: shadowed global variable
Running ../../../src/gdb/testsuite/gdb.cp/m-static.exp ...
-PASS: gdb.cp/m-static.exp: continue to breakpoint: end of constructors
-PASS: gdb.cp/m-static.exp: simple object, static const bool
-PASS: gdb.cp/m-static.exp: simple object, static const int
-PASS: gdb.cp/m-static.exp: simple object, static long
-PASS: gdb.cp/m-static.exp: simple object, static enum
-PASS: gdb.cp/m-static.exp: derived template object, base static const bool
-PASS: gdb.cp/m-static.exp: derived template object, base static const int
-PASS: gdb.cp/m-static.exp: derived template object, base static long
-PASS: gdb.cp/m-static.exp: derived template object, base static enum
-PASS: gdb.cp/m-static.exp: derived template object, static enum
-PASS: gdb.cp/m-static.exp: template object, static const bool
-PASS: gdb.cp/m-static.exp: template object, static const int
-PASS: gdb.cp/m-static.exp: template object, static long
-PASS: gdb.cp/m-static.exp: template object, static enum
-PASS: gdb.cp/m-static.exp: template object, static derived enum
-PASS: gdb.cp/m-static.exp: static const int initialized elsewhere
-PASS: gdb.cp/m-static.exp: static const int initialized nowhere
+ERROR: couldn't open "../../../src/gdb/testsuite/gdb.cp/../../../src/gdb/testsuite/gdb.cp/m-static.cc": no such file or directory
+UNRESOLVED: gdb.cp/m-static.exp: continue to breakpoint: end of constructors
+FAIL: gdb.cp/m-static.exp: simple object, static const bool
+FAIL: gdb.cp/m-static.exp: simple object, static const int
+FAIL: gdb.cp/m-static.exp: simple object, static long
+FAIL: gdb.cp/m-static.exp: simple object, static enum
+FAIL: gdb.cp/m-static.exp: derived template object, base static const bool
+FAIL: gdb.cp/m-static.exp: derived template object, base static const int
+FAIL: gdb.cp/m-static.exp: derived template object, base static long
+FAIL: gdb.cp/m-static.exp: derived template object, base static enum
+FAIL: gdb.cp/m-static.exp: derived template object, static enum
+FAIL: gdb.cp/m-static.exp: template object, static const bool
+FAIL: gdb.cp/m-static.exp: template object, static const int
+FAIL: gdb.cp/m-static.exp: template object, static long
+FAIL: gdb.cp/m-static.exp: template object, static enum
+FAIL: gdb.cp/m-static.exp: template object, static derived enum
+FAIL: gdb.cp/m-static.exp: static const int initialized elsewhere
+FAIL: gdb.cp/m-static.exp: static const int initialized nowhere
Running ../../../src/gdb/testsuite/gdb.cp/maint.exp ...
PASS: gdb.cp/maint.exp: help maintenance cplus
PASS: gdb.cp/maint.exp: help maint cp
@@ -10523,10 +10524,11 @@
=== gdb Summary ===
-# of expected passes 9922
-# of unexpected failures 54
+# of expected passes 9901
+# of unexpected failures 72
# of expected failures 147
# of known failures 35
+# of unresolved testcases 2
# of untested testcases 4
# of unsupported tests 20
/home/kettenis/sandbox/gdb/obj/gdb/testsuite/../../gdb/gdb version 2004-08-09-cvs -nx
next prev parent reply other threads:[~2004-08-09 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 16:14 Michael Chastain
2004-08-09 17:55 ` Mark Kettenis
2004-08-09 19:47 ` Michael Chastain
2004-08-09 20:22 ` Mark Kettenis [this message]
2004-08-09 22:18 ` [rfc/testsuite/cp] make all srcfile look the same Michael Chastain
2004-08-15 9:21 ` Michael Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408092022.i79KMQwm057980@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox