From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28641 invoked by alias); 9 Aug 2004 20:22:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28615 invoked from network); 9 Aug 2004 20:22:30 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 9 Aug 2004 20:22:30 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i79KMRZt000974; Mon, 9 Aug 2004 22:22:27 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i79KMQmT057983; Mon, 9 Aug 2004 22:22:26 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i79KMQwm057980; Mon, 9 Aug 2004 22:22:26 +0200 (CEST) Date: Mon, 09 Aug 2004 20:22:00 -0000 Message-Id: <200408092022.i79KMQwm057980@elgar.kettenis.dyndns.org> From: Mark Kettenis To: mec.gnu@mindspring.com CC: gdb-patches@sources.redhat.com In-reply-to: <4117D4E9.nailNML1MZER2@mindspring.com> (message from Michael Chastain on Mon, 09 Aug 2004 15:47:53 -0400) Subject: Re: [patch/testsuite] lib/gdb.exp: native tcl gdb_get_line_number References: <4116516C.nailLPL1BAKH4@mindspring.com> <200408091755.i79Hta9D038666@elgar.kettenis.dyndns.org> <4117D4E9.nailNML1MZER2@mindspring.com> X-SW-Source: 2004-08/txt/msg00335.txt.bz2 Date: Mon, 09 Aug 2004 15:47:53 -0400 From: Michael Chastain > The attached patch fixes things for me, but can somebody please check > whether i've escaped the dot correctly? I'm going to think about this problem a bit. I don't really like that compatibility kludge in the first place, and I'd rather bust some heads in the callers and de-kludge this rather then en-kludge it some more. So this patch is not approved. (If I don't get the problem fixed pretty quick then I'll have to accept it though). OK. Which files are causing problems on your system? On my system, the intersection between gdb_get_line_number and ${srcfile*} with a "/" in them is: gdb.cp/ctti.exp gdb.cp/m-static.exp So I would have to change two callers. Looks like you're right. Here's a diff of the testsuite resuults: --- ../testresults/20040808/gdb.sum Mon Aug 9 22:05:51 2004 +++ gdb/testsuite/gdb.sum Mon Aug 9 22:13:51 2004 @@ -1,4 +1,4 @@ -Test Run By kettenis on Mon Aug 9 22:00:30 2004 +Test Run By kettenis on Mon Aug 9 22:09:33 2004 Native configuration is i386-unknown-freebsd4.7 === gdb tests === @@ -7027,10 +7026,11 @@ PASS: gdb.cp/cplusfuncs.exp: info function for "operator()(" PASS: gdb.cp/cplusfuncs.exp: info function for "operator char \*(" Running ../../../src/gdb/testsuite/gdb.cp/ctti.exp ... -PASS: gdb.cp/ctti.exp: continue to breakpoint: marker add1 -PASS: gdb.cp/ctti.exp: print c -PASS: gdb.cp/ctti.exp: print f -PASS: gdb.cp/ctti.exp: print i +ERROR: couldn't open "../../../src/gdb/testsuite/gdb.cp/../../../src/gdb/testsuite/gdb.cp/cttiadd.cc": no such file or directory +UNRESOLVED: gdb.cp/ctti.exp: continue to breakpoint: marker add1 +FAIL: gdb.cp/ctti.exp: print c +FAIL: gdb.cp/ctti.exp: print f +FAIL: gdb.cp/ctti.exp: print i Running ../../../src/gdb/testsuite/gdb.cp/demangle.exp ... PASS: gdb.cp/demangle.exp: lucid: set demangle-style PASS: gdb.cp/demangle.exp: lucid: check demangling style @@ -8104,23 +8104,24 @@ PASS: gdb.cp/m-data.exp: shadowing member PASS: gdb.cp/m-data.exp: shadowed global variable Running ../../../src/gdb/testsuite/gdb.cp/m-static.exp ... -PASS: gdb.cp/m-static.exp: continue to breakpoint: end of constructors -PASS: gdb.cp/m-static.exp: simple object, static const bool -PASS: gdb.cp/m-static.exp: simple object, static const int -PASS: gdb.cp/m-static.exp: simple object, static long -PASS: gdb.cp/m-static.exp: simple object, static enum -PASS: gdb.cp/m-static.exp: derived template object, base static const bool -PASS: gdb.cp/m-static.exp: derived template object, base static const int -PASS: gdb.cp/m-static.exp: derived template object, base static long -PASS: gdb.cp/m-static.exp: derived template object, base static enum -PASS: gdb.cp/m-static.exp: derived template object, static enum -PASS: gdb.cp/m-static.exp: template object, static const bool -PASS: gdb.cp/m-static.exp: template object, static const int -PASS: gdb.cp/m-static.exp: template object, static long -PASS: gdb.cp/m-static.exp: template object, static enum -PASS: gdb.cp/m-static.exp: template object, static derived enum -PASS: gdb.cp/m-static.exp: static const int initialized elsewhere -PASS: gdb.cp/m-static.exp: static const int initialized nowhere +ERROR: couldn't open "../../../src/gdb/testsuite/gdb.cp/../../../src/gdb/testsuite/gdb.cp/m-static.cc": no such file or directory +UNRESOLVED: gdb.cp/m-static.exp: continue to breakpoint: end of constructors +FAIL: gdb.cp/m-static.exp: simple object, static const bool +FAIL: gdb.cp/m-static.exp: simple object, static const int +FAIL: gdb.cp/m-static.exp: simple object, static long +FAIL: gdb.cp/m-static.exp: simple object, static enum +FAIL: gdb.cp/m-static.exp: derived template object, base static const bool +FAIL: gdb.cp/m-static.exp: derived template object, base static const int +FAIL: gdb.cp/m-static.exp: derived template object, base static long +FAIL: gdb.cp/m-static.exp: derived template object, base static enum +FAIL: gdb.cp/m-static.exp: derived template object, static enum +FAIL: gdb.cp/m-static.exp: template object, static const bool +FAIL: gdb.cp/m-static.exp: template object, static const int +FAIL: gdb.cp/m-static.exp: template object, static long +FAIL: gdb.cp/m-static.exp: template object, static enum +FAIL: gdb.cp/m-static.exp: template object, static derived enum +FAIL: gdb.cp/m-static.exp: static const int initialized elsewhere +FAIL: gdb.cp/m-static.exp: static const int initialized nowhere Running ../../../src/gdb/testsuite/gdb.cp/maint.exp ... PASS: gdb.cp/maint.exp: help maintenance cplus PASS: gdb.cp/maint.exp: help maint cp @@ -10523,10 +10524,11 @@ === gdb Summary === -# of expected passes 9922 -# of unexpected failures 54 +# of expected passes 9901 +# of unexpected failures 72 # of expected failures 147 # of known failures 35 +# of unresolved testcases 2 # of untested testcases 4 # of unsupported tests 20 /home/kettenis/sandbox/gdb/obj/gdb/testsuite/../../gdb/gdb version 2004-08-09-cvs -nx