Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: drow@false.org.mec.gnu@mindspring.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [testsuite] kfail sigaltstack.exp on i386/gnu/linux
Date: Mon, 09 Aug 2004 17:27:00 -0000	[thread overview]
Message-ID: <200408091708.i79H8sQQ032899@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20040808220220.GA22738@nevyn.them.org> (message from Daniel Jacobowitz on Sun, 8 Aug 2004 18:02:20 -0400)

   Date: Sun, 8 Aug 2004 18:02:20 -0400
   From: Daniel Jacobowitz <drow@false.org>

   2004-08-08  Daniel Jacobowitz  <dan@debian.org>

	   PR gdb/1736
	   * gdb.base/sigaltstack.exp (finish_test): New procedure.  KFAIL
	   for i?86-*-linux*.

Sorry Daniel, this patch isn't right.  The tests get out of sync on my
i386-unknown-freebsd4.7 system.  You can't blindly convert from
gdb_test to gdb_test_multiple.  The latter doesn't provide proper
anchoring.  The attached patch fixes that.  Is this OK Michael?

Index: testsuite/ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* gdb.base/sigaltstack.exp: Provide proper anchoring.

Index: testsuite/gdb.base/sigaltstack.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/sigaltstack.exp,v
retrieving revision 1.3
diff -u -p -r1.3 sigaltstack.exp
--- testsuite/gdb.base/sigaltstack.exp 9 Aug 2004 13:16:16 -0000 1.3
+++ testsuite/gdb.base/sigaltstack.exp 9 Aug 2004 17:07:51 -0000
@@ -89,7 +89,7 @@ proc finish_test { pattern msg } {
 	    setup_kfail "i?86-*-linux*" gdb/1736
 	    fail "$msg (could not set breakpoint)"
 	}
-	-re "$pattern" {
+	-re "$pattern.*${gdb_prompt} $" {
 	    pass $msg
 	}
     }




      parent reply	other threads:[~2004-08-09 17:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-08 22:02 Daniel Jacobowitz
2004-08-08 22:22 ` Michael Chastain
2004-08-08 23:14   ` Daniel Jacobowitz
2004-08-09  6:59     ` Michael Chastain
2004-08-09 17:15 ` Mark Kettenis
2004-08-09 17:30   ` Daniel Jacobowitz
2004-08-09 18:50     ` Michael Chastain
2004-08-09 17:27 ` Mark Kettenis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200408091708.i79H8sQQ032899@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=drow@false.org.mec.gnu \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox