From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29195 invoked by alias); 9 Aug 2004 17:27:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29181 invoked from network); 9 Aug 2004 17:27:25 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 9 Aug 2004 17:27:25 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i79HROZt000644 for ; Mon, 9 Aug 2004 19:27:24 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i79HRNmT033012 for ; Mon, 9 Aug 2004 19:27:23 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i79H8sQQ032899; Mon, 9 Aug 2004 19:08:54 +0200 (CEST) Date: Mon, 09 Aug 2004 17:27:00 -0000 Message-Id: <200408091708.i79H8sQQ032899@elgar.kettenis.dyndns.org> From: Mark Kettenis To: drow@false.org.mec.gnu@mindspring.com CC: gdb-patches@sources.redhat.com In-reply-to: <20040808220220.GA22738@nevyn.them.org> (message from Daniel Jacobowitz on Sun, 8 Aug 2004 18:02:20 -0400) Subject: Re: [testsuite] kfail sigaltstack.exp on i386/gnu/linux References: <20040808220220.GA22738@nevyn.them.org> X-SW-Source: 2004-08/txt/msg00320.txt.bz2 Date: Sun, 8 Aug 2004 18:02:20 -0400 From: Daniel Jacobowitz 2004-08-08 Daniel Jacobowitz PR gdb/1736 * gdb.base/sigaltstack.exp (finish_test): New procedure. KFAIL for i?86-*-linux*. Sorry Daniel, this patch isn't right. The tests get out of sync on my i386-unknown-freebsd4.7 system. You can't blindly convert from gdb_test to gdb_test_multiple. The latter doesn't provide proper anchoring. The attached patch fixes that. Is this OK Michael? Index: testsuite/ChangeLog from Mark Kettenis * gdb.base/sigaltstack.exp: Provide proper anchoring. Index: testsuite/gdb.base/sigaltstack.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/sigaltstack.exp,v retrieving revision 1.3 diff -u -p -r1.3 sigaltstack.exp --- testsuite/gdb.base/sigaltstack.exp 9 Aug 2004 13:16:16 -0000 1.3 +++ testsuite/gdb.base/sigaltstack.exp 9 Aug 2004 17:07:51 -0000 @@ -89,7 +89,7 @@ proc finish_test { pattern msg } { setup_kfail "i?86-*-linux*" gdb/1736 fail "$msg (could not set breakpoint)" } - -re "$pattern" { + -re "$pattern.*${gdb_prompt} $" { pass $msg } }