Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Cc: Andrew Cagney <cagney@redhat.com>,
	Peter Schauer <Peter.Schauer@regent.e-technik.tu-muenchen.de>,
	Kevin Buettner <kevinb@redhat.com>
Subject: [RFC/AIX] xm-aix4.h - get rid of #undef fd_set & select #include
Date: Sun, 08 Aug 2004 04:26:00 -0000	[thread overview]
Message-ID: <20040808042601.GA24160@gnat.com> (raw)

config/xm-aix4.h contains the following definitions:

| /* The following text is taken from config/rs6000.mh:
|  * # The IBM version of /usr/include/rpc/rpc.h has a bug -- it says
|  * # `extern fd_set svc_fdset;' without ever defining the type fd_set.
|  * # Unfortunately this occurs in the vx-share code, which is not configured
|  * # like the rest of GDB (e.g. it doesn't include "defs.h").
|  * # We circumvent this bug by #define-ing fd_set here, but undefining it in
|  * # the xm-rs6000.h file before ordinary modules try to use it.  FIXME, IBM!
|  * MH_CFLAGS='-Dfd_set=int'
|  * So, here we do the undefine...which has to occur before we include
|  * <sys/select.h> below.
|  */
| #undef fd_set
| 
| #include <sys/select.h>

On our systems (AIX 4.3.2 and 5.1), this type is defined in time.h

    typedef struct
    #ifdef _ALL_SOURCE
    fd_set
    #endif /* _ALL_SOURCE */
    {
      long fds_bits[__NUM_ENTRIES];  /* bitmask for open file descriptors */
    } fd_set;

I couldn't find config/rs6000.mh, nor the original comment. So I wonder
if we wouldn't be able to delete these two.

I can give it a try, but would I miss something?

-- 
Joel


             reply	other threads:[~2004-08-08  4:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-08  4:26 Joel Brobecker [this message]
2004-08-09 18:23 ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040808042601.GA24160@gnat.com \
    --to=brobecker@gnat.com \
    --cc=Peter.Schauer@regent.e-technik.tu-muenchen.de \
    --cc=cagney@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox