From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-34999-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 3043 invoked by alias); 8 Aug 2004 04:26:03 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 3033 invoked from network); 8 Aug 2004 04:26:02 -0000
Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108)
  by sourceware.org with SMTP; 8 Aug 2004 04:26:02 -0000
Received: by takamaka.act-europe.fr (Postfix, from userid 507)
	id 9435547D91; Sat,  7 Aug 2004 21:26:01 -0700 (PDT)
Date: Sun, 08 Aug 2004 04:26:00 -0000
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Cc: Andrew Cagney <cagney@redhat.com>,
	Peter Schauer <Peter.Schauer@regent.e-technik.tu-muenchen.de>,
	Kevin Buettner <kevinb@redhat.com>
Subject: [RFC/AIX] xm-aix4.h - get rid of #undef fd_set & select #include
Message-ID: <20040808042601.GA24160@gnat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4i
X-SW-Source: 2004-08/txt/msg00230.txt.bz2

config/xm-aix4.h contains the following definitions:

| /* The following text is taken from config/rs6000.mh:
|  * # The IBM version of /usr/include/rpc/rpc.h has a bug -- it says
|  * # `extern fd_set svc_fdset;' without ever defining the type fd_set.
|  * # Unfortunately this occurs in the vx-share code, which is not configured
|  * # like the rest of GDB (e.g. it doesn't include "defs.h").
|  * # We circumvent this bug by #define-ing fd_set here, but undefining it in
|  * # the xm-rs6000.h file before ordinary modules try to use it.  FIXME, IBM!
|  * MH_CFLAGS='-Dfd_set=int'
|  * So, here we do the undefine...which has to occur before we include
|  * <sys/select.h> below.
|  */
| #undef fd_set
| 
| #include <sys/select.h>

On our systems (AIX 4.3.2 and 5.1), this type is defined in time.h

    typedef struct
    #ifdef _ALL_SOURCE
    fd_set
    #endif /* _ALL_SOURCE */
    {
      long fds_bits[__NUM_ENTRIES];  /* bitmask for open file descriptors */
    } fd_set;

I couldn't find config/rs6000.mh, nor the original comment. So I wonder
if we wouldn't be able to delete these two.

I can give it a try, but would I miss something?

-- 
Joel