From: Mark Kettenis <kettenis@chello.nl>
To: hunt@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] read_reg() patch
Date: Thu, 29 Jul 2004 22:48:00 -0000 [thread overview]
Message-ID: <200407292247.i6TMlhm3024105@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <1090875453.3021.2.camel@dragon> (hunt@redhat.com)
From: "Martin M. Hunt" <hunt@redhat.com>
Date: Mon, 26 Jul 2004 13:57:34 -0700
> I also think that the code itself is pretty unreadable. There are too
> many nested function calls. I think it could be improved by using a
> (temporary) local variable to store the result of
> extract_unsigned_integer().
How's this?
2004-07-26 Martin Hunt <hunt@redhat.com>
* dwarf2-frame.c (read_reg): Add a call to
store_unsigned_integer.
Great, although I'd chose a somewhat less generic name for the
variable than `tmp'; although the `val' I've got in mind is pretty
generic too :-(. However, the type shouldn't be CORE_ADDR, but
ULONGEST. Consider a patch with that change pre-approved.
Mark
prev parent reply other threads:[~2004-07-29 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-20 19:17 Martin M. Hunt
2004-07-21 20:36 ` Mark Kettenis
2004-07-26 20:57 ` Martin M. Hunt
2004-07-29 22:48 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200407292247.i6TMlhm3024105@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=hunt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox