From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8198 invoked by alias); 29 Jul 2004 22:48:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8185 invoked from network); 29 Jul 2004 22:48:16 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 29 Jul 2004 22:48:16 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i6TMliJ8018516; Fri, 30 Jul 2004 00:47:44 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i6TMliMA024108; Fri, 30 Jul 2004 00:47:44 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i6TMlhm3024105; Fri, 30 Jul 2004 00:47:43 +0200 (CEST) Date: Thu, 29 Jul 2004 22:48:00 -0000 Message-Id: <200407292247.i6TMlhm3024105@elgar.kettenis.dyndns.org> From: Mark Kettenis To: hunt@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <1090875453.3021.2.camel@dragon> (hunt@redhat.com) Subject: Re: [RFA] read_reg() patch References: <1090351011.3030.12.camel@dragon> <200407212036.i6LKaE0V009860@copland.kettenis.dyndns.org> <1090875453.3021.2.camel@dragon> X-SW-Source: 2004-07/txt/msg00465.txt.bz2 From: "Martin M. Hunt" Date: Mon, 26 Jul 2004 13:57:34 -0700 > I also think that the code itself is pretty unreadable. There are too > many nested function calls. I think it could be improved by using a > (temporary) local variable to store the result of > extract_unsigned_integer(). How's this? 2004-07-26 Martin Hunt * dwarf2-frame.c (read_reg): Add a call to store_unsigned_integer. Great, although I'd chose a somewhat less generic name for the variable than `tmp'; although the `val' I've got in mind is pretty generic too :-(. However, the type shouldn't be CORE_ADDR, but ULONGEST. Consider a patch with that change pre-approved. Mark