Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Re: src/gdb/testsuite ChangeLog lib/insight-suppor ...
@ 2004-07-14 20:46 Michael Elizabeth Chastain
  2004-07-14 20:48 ` Daniel Jacobowitz
  2004-07-14 21:59 ` Martin M. Hunt
  0 siblings, 2 replies; 5+ messages in thread
From: Michael Elizabeth Chastain @ 2004-07-14 20:46 UTC (permalink / raw)
  To: hunt; +Cc: gdb-patches

Hi Martin,

I didn't see this patch go by in gdb-patches@.  Please send the
patch to gdb-patches@ first, and get the approval of the testsuite
maintainer (me), before committing it!

This one's already committed, but can you whip up something anyways: the
patch, plus more explanation of the problems that you ran into, plus a
description of the system that you tested it on.  For the record.

So if next month somebody else has a problem because TCL_LIBRARY
is not set, it will be a lot easier to understand all the cases,
instead of just "well someone took out this line last month
but we're hazy on why".

Thanks,

Michael C

===

	2004-07-14  Martin Hunt  <hunt@redhat.com>
	
	* lib/insight-support.exp (gdbtk_start): Unset TCL_LIBRARY
	which fixes some problems where init.tcl was not found.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: src/gdb/testsuite ChangeLog lib/insight-suppor ...
  2004-07-14 20:46 src/gdb/testsuite ChangeLog lib/insight-suppor Michael Elizabeth Chastain
@ 2004-07-14 20:48 ` Daniel Jacobowitz
  2004-07-14 21:59 ` Martin M. Hunt
  1 sibling, 0 replies; 5+ messages in thread
From: Daniel Jacobowitz @ 2004-07-14 20:48 UTC (permalink / raw)
  To: Michael Elizabeth Chastain; +Cc: hunt, gdb-patches

On Wed, Jul 14, 2004 at 04:46:03PM -0400, Michael Chastain wrote:
> Hi Martin,
> 
> I didn't see this patch go by in gdb-patches@.  Please send the
> patch to gdb-patches@ first, and get the approval of the testsuite
> maintainer (me), before committing it!

Is this file part of GDB?  I don't really think so, since none of the
rest of Insight is.

-- 
Daniel Jacobowitz


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: src/gdb/testsuite ChangeLog lib/insight-suppor ...
  2004-07-14 20:46 src/gdb/testsuite ChangeLog lib/insight-suppor Michael Elizabeth Chastain
  2004-07-14 20:48 ` Daniel Jacobowitz
@ 2004-07-14 21:59 ` Martin M. Hunt
  2004-07-17  2:09   ` [commit/6.2] Fix lib (C)s; Was: " Andrew Cagney
  1 sibling, 1 reply; 5+ messages in thread
From: Martin M. Hunt @ 2004-07-14 21:59 UTC (permalink / raw)
  To: Michael Elizabeth Chastain; +Cc: hunt, gdb-patches

On Wed, 2004-07-14 at 13:46, Michael Elizabeth Chastain wrote:
> Hi Martin,
> 
> I didn't see this patch go by in gdb-patches@.  Please send the
> patch to gdb-patches@ first, and get the approval of the testsuite
> maintainer (me), before committing it!

I thought that was mine because its Insight and not GDB.  Anyway can't
hurt to post it, so I did.
 
-- 
Martin M. Hunt <hunt@redhat.com>
Red Hat Inc.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [commit/6.2] Fix lib (C)s; Was: src/gdb/testsuite ChangeLog lib/insight-suppor ...
  2004-07-14 21:59 ` Martin M. Hunt
@ 2004-07-17  2:09   ` Andrew Cagney
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Cagney @ 2004-07-17  2:09 UTC (permalink / raw)
  To: Martin M. Hunt, Michael Elizabeth Chastain; +Cc: hunt, gdb-patches

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

FYI,

I've checked this in.  Wacks a further two (C) problems (the file was 
moved to an insight directory).

committed to mainline and 6.2,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1345 bytes --]

2004-07-16  Andrew Cagney  <cagney@redhat.com>

	* lib/insight-support.exp: Delete file.
	* lib/java.exp (java_init): Fix copyright.

Index: lib/java.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/java.exp,v
retrieving revision 1.2
diff -p -u -r1.2 java.exp
--- lib/java.exp	25 Sep 2003 16:25:56 -0000	1.2
+++ lib/java.exp	17 Jul 2004 02:01:55 -0000
@@ -1,4 +1,20 @@
-# Copyright (C) 1998, 1999 Red Hat, Inc.
+# This test code is part of GDB, the GNU debugger.
+
+# Copyright 1998, 1999, 2000, 2003 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+# 
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+# 
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  
 
 load_lib "libgloss.exp"
 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: src/gdb/testsuite ChangeLog lib/insight-suppor ...
@ 2004-07-15  1:49 Michael Elizabeth Chastain
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Elizabeth Chastain @ 2004-07-15  1:49 UTC (permalink / raw)
  To: hunt; +Cc: gdb-patches

> I thought that was mine because its Insight and not GDB.

All I know is what I read in MAINTAINERS.
 
> Anyway can't hurt to post it, so I did.

Thanks.

Michael C


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-07-17  2:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-07-14 20:46 src/gdb/testsuite ChangeLog lib/insight-suppor Michael Elizabeth Chastain
2004-07-14 20:48 ` Daniel Jacobowitz
2004-07-14 21:59 ` Martin M. Hunt
2004-07-17  2:09   ` [commit/6.2] Fix lib (C)s; Was: " Andrew Cagney
2004-07-15  1:49 Michael Elizabeth Chastain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox