Re: gdb.base/attach.exp cleanupfile?

Re: gdb.base/attach.exp cleanupfile?

[Michael Elizabeth Chastain]

cv> This code is in attach.exp since epoch, but AFAICS, there was never
cv> a file called attach.awk in the repository.

attach.exp was originally in testsuite/gdb.hp/attach.exp.
It came in with the HP merge, changelong entry of 1999-01-04.
I found it in gdb 4.18.

I didn't find any *.awk files in any gdb testsuite release
from gdb 4.10 to gdb 6.0.

I bet that attach.awk was supposed to be included in the 1999
hp merge but got lost somewhere along the way.  We have lived
without it since then.

> Does anybody know if that's good for anything?  If not, I'll remove
> that code from attach.exp as an obfix.

Okay by me.  Copyright date + a trivial test run => commit it!

Michael C

Re: gdb.base/attach.exp cleanupfile?

[Corinna Vinschen]

On Jul 12 19:48, Michael Elizabeth Chastain wrote:
> cv> This code is in attach.exp since epoch, but AFAICS, there was never
> cv> a file called attach.awk in the repository.
> 
> Okay by me.  Copyright date + a trivial test run => commit it!

Copyright date was ok already, tested on Linux.  I've applied the following
patch.

	* gdb.base/attach.exp: Remove cleanupfile handling.

Index: gdb.base/attach.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/attach.exp,v
retrieving revision 1.16
diff -u -p -r1.16 attach.exp
--- gdb.base/attach.exp 12 Jul 2004 14:25:48 -0000      1.16
+++ gdb.base/attach.exp 13 Jul 2004 09:50:12 -0000
@@ -43,7 +43,6 @@ set srcfile2 ${testfile}2.c
 set binfile  ${objdir}/${subdir}/${testfile}
 set binfile2 ${objdir}/${subdir}/${testfile}2
 set escapedbinfile  [string_to_regexp ${objdir}/${subdir}/${testfile}]
-set cleanupfile ${objdir}/${subdir}/${testfile}.awk
 
 #execute_anywhere "rm -f ${binfile} ${binfile2}"
 remote_exec build "rm -f ${binfile} ${binfile2}"
@@ -51,10 +50,6 @@ remote_exec build "rm -f ${binfile} ${bi
 #
 #log_user 1
 
-# Clean out any old files from past runs.
-#
-remote_exec build "${cleanupfile}"
-
 # build the first test case
 #
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.

Re: gdb.base/attach.exp cleanupfile?

[Michael Elizabeth Chastain]

> This code is in attach.exp since epoch, but AFAICS, there was never
> a file called attach.awk in the repository.

I will look before the epoch, in the old 4.X release tarballs.
I'll get back to you in several hours.

I like to garbage collect old stuff, but I like to understand how
it got that way before purging it.

Michael C