From: Daniel Jacobowitz <drow@false.org>
To: Andreas Schwab <schwab@suse.de>
Cc: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>,
Andrew Cagney <cagney@gnu.org>,
gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix frame ID comparison problem on s390
Date: Sun, 27 Jun 2004 23:11:00 -0000 [thread overview]
Message-ID: <20040627231144.GA992@nevyn.them.org> (raw)
In-Reply-To: <jeeko0mx3c.fsf@sykes.suse.de>
On Mon, Jun 28, 2004 at 12:53:43AM +0200, Andreas Schwab wrote:
> Daniel Jacobowitz <drow@false.org> writes:
>
> >> + /* Flags to indicate the above fields have valid contents. */
> >> + int stack_addr_p : 1;
> >> + int code_addr_p : 1;
> >> + int special_addr_p : 1;
> >> };
> >>
> >> /* Methods for constructing and comparing Frame IDs.
> >
> > Some future version of GCC will warn about this mistake. The only
> > valid values for "int : 1" are 0 and -1.
>
> Actually it can be both 0/-1 and 0/1, since it is implementation defined
> whether unadorned int bitfields are signed or unsigned.
Huh, thank you. In any case, thanks for making this explicit, Ulrich.
--
Daniel Jacobowitz
prev parent reply other threads:[~2004-06-27 23:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-20 13:31 Ulrich Weigand
2004-05-20 14:17 ` Daniel Jacobowitz
2004-05-24 13:45 ` Ulrich Weigand
2004-05-24 18:52 ` Andrew Cagney
2004-06-09 14:12 ` Ulrich Weigand
2004-06-09 14:55 ` Andrew Cagney
2004-06-16 13:48 ` Ulrich Weigand
2004-06-16 17:33 ` Andrew Cagney
2004-06-27 20:48 ` Ulrich Weigand
2004-06-27 21:48 ` Daniel Jacobowitz
2004-06-27 22:35 ` Ulrich Weigand
2004-06-27 22:59 ` Andreas Schwab
2004-06-27 23:11 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040627231144.GA992@nevyn.them.org \
--to=drow@false.org \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=schwab@suse.de \
--cc=weigand@i1.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox