From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17117 invoked by alias); 27 Jun 2004 23:11:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17110 invoked from network); 27 Jun 2004 23:11:47 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 27 Jun 2004 23:11:47 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BeioK-0000Hg-FT; Sun, 27 Jun 2004 19:11:44 -0400 Date: Sun, 27 Jun 2004 23:11:00 -0000 From: Daniel Jacobowitz To: Andreas Schwab Cc: Ulrich Weigand , Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix frame ID comparison problem on s390 Message-ID: <20040627231144.GA992@nevyn.them.org> Mail-Followup-To: Andreas Schwab , Ulrich Weigand , Andrew Cagney , gdb-patches@sources.redhat.com References: <40D08438.8090009@gnu.org> <200406272047.WAA10464@faui1m.informatik.uni-erlangen.de> <20040627214831.GA30684@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-06/txt/msg00621.txt.bz2 On Mon, Jun 28, 2004 at 12:53:43AM +0200, Andreas Schwab wrote: > Daniel Jacobowitz writes: > > >> + /* Flags to indicate the above fields have valid contents. */ > >> + int stack_addr_p : 1; > >> + int code_addr_p : 1; > >> + int special_addr_p : 1; > >> }; > >> > >> /* Methods for constructing and comparing Frame IDs. > > > > Some future version of GCC will warn about this mistake. The only > > valid values for "int : 1" are 0 and -1. > > Actually it can be both 0/-1 and 0/1, since it is implementation defined > whether unadorned int bitfields are signed or unsigned. Huh, thank you. In any case, thanks for making this explicit, Ulrich. -- Daniel Jacobowitz