* [RFA] minor top-level configure.in fix
@ 2004-06-21 22:59 Christopher Faylor
2004-06-21 23:02 ` DJ Delorie
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Faylor @ 2004-06-21 22:59 UTC (permalink / raw)
To: gdb-patches, binutils, gcc-patches
I think this qualifies as an obvious fix. Ok to checkin?
cgf
2004-06-21 Christopher Faylor <cgf@alum.bu.edu>
* configure.in: Check for srcdir/winsup rather than
build directory winsup.
* configure: Regenerate.
Index: configure.in
===================================================================
RCS file: /cvs/uberbaum/configure.in,v
retrieving revision 1.296
diff -d -u -p -r1.296 configure.in
--- configure.in 17 Jun 2004 19:54:25 -0000 1.296
+++ configure.in 21 Jun 2004 22:58:48 -0000
@@ -586,7 +586,7 @@ case "${target}" in
target_configdirs="$target_configdirs target-libtermcap target-winsup"
noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
# always build newlib if winsup directory is present.
- if test -d winsup
+ if test -d "$srcdir/winsup"
then
skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
else
Index: configure
===================================================================
RCS file: /cvs/uberbaum/configure,v
retrieving revision 1.158
diff -d -u -p -r1.158 configure
--- configure 17 Jun 2004 19:54:25 -0000 1.158
+++ configure 21 Jun 2004 22:58:49 -0000
@@ -1366,7 +1366,7 @@ case "${target}" in
target_configdirs="$target_configdirs target-libtermcap target-winsup"
noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
# always build newlib if winsup directory is present.
- if test -d winsup
+ if test -d $srcdir/winsup
then
skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
else
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] minor top-level configure.in fix
2004-06-21 22:59 [RFA] minor top-level configure.in fix Christopher Faylor
@ 2004-06-21 23:02 ` DJ Delorie
2004-06-22 1:40 ` Christopher Faylor
0 siblings, 1 reply; 3+ messages in thread
From: DJ Delorie @ 2004-06-21 23:02 UTC (permalink / raw)
To: me; +Cc: gdb-patches, binutils, gcc-patches
> I think this qualifies as an obvious fix. Ok to checkin?
Yeah. Why is one quoted and the other not, though?
> 2004-06-21 Christopher Faylor <cgf@alum.bu.edu>
>
> * configure.in: Check for srcdir/winsup rather than
> build directory winsup.
> * configure: Regenerate.
>
> Index: configure.in
> ===================================================================
> RCS file: /cvs/uberbaum/configure.in,v
> retrieving revision 1.296
> diff -d -u -p -r1.296 configure.in
> --- configure.in 17 Jun 2004 19:54:25 -0000 1.296
> +++ configure.in 21 Jun 2004 22:58:48 -0000
> @@ -586,7 +586,7 @@ case "${target}" in
> target_configdirs="$target_configdirs target-libtermcap target-winsup"
> noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
> # always build newlib if winsup directory is present.
> - if test -d winsup
> + if test -d "$srcdir/winsup"
> then
> skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
> else
> Index: configure
> ===================================================================
> RCS file: /cvs/uberbaum/configure,v
> retrieving revision 1.158
> diff -d -u -p -r1.158 configure
> --- configure 17 Jun 2004 19:54:25 -0000 1.158
> +++ configure 21 Jun 2004 22:58:49 -0000
> @@ -1366,7 +1366,7 @@ case "${target}" in
> target_configdirs="$target_configdirs target-libtermcap target-winsup"
> noconfigdirs="$noconfigdirs target-gperf target-libgloss ${libgcj}"
> # always build newlib if winsup directory is present.
> - if test -d winsup
> + if test -d $srcdir/winsup
> then
> skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
> else
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] minor top-level configure.in fix
2004-06-21 23:02 ` DJ Delorie
@ 2004-06-22 1:40 ` Christopher Faylor
0 siblings, 0 replies; 3+ messages in thread
From: Christopher Faylor @ 2004-06-22 1:40 UTC (permalink / raw)
To: DJ Delorie; +Cc: gdb-patches, binutils, gcc-patches
On Mon, Jun 21, 2004 at 07:01:20PM -0400, DJ Delorie wrote:
>>I think this qualifies as an obvious fix. Ok to checkin?
>
>Yeah. Why is one quoted and the other not, though?
When I regenerated configure with the ancient version of autoconf
that I usually use for this stuff, I had a lot of gratuitous changes.
So, since the change was small, I hand-edited configure rather than
regenerate it. Of course, I screwed up. The quoted form should be
correct, especially on Windows where they like to use spaces in
directory names.
I've checked in the change with the quotes.
cgf
>> 2004-06-21 Christopher Faylor <cgf@alum.bu.edu>
>>
>> * configure.in: Check for srcdir/winsup rather than
>> build directory winsup.
>> * configure: Regenerate.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-06-22 1:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-21 22:59 [RFA] minor top-level configure.in fix Christopher Faylor
2004-06-21 23:02 ` DJ Delorie
2004-06-22 1:40 ` Christopher Faylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox