Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
To: cagney@gnu.org, mec.gnu@mindspring.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/testsuite] Extend signull to work with discriptors
Date: Wed, 16 Jun 2004 15:39:00 -0000	[thread overview]
Message-ID: <20040616153901.0B93F4B104@berman.michael-chastain.com> (raw)

> We're going to have to live with this - the testsuite needs to include 
> deliberately erroneous programs.

Yeah, I see what you're saying, and I agree.  It's not like the test
program is gratuitously non-conforming.  You need this 'desc' to do what
it's doing in order to test what you're testing.

Can you add one more comment?  Something like:

  /* desc is intentionally initialized to a data object.
     This is needed to test descriptors on arches like ia64.  */

It's the old "move the mailing list discussion into a comment" request.

With a comment like this, this patch is approved.  (And also maybe you
have better wording for the comment than I can think of).

Michael C

> 2004-06-15  Andrew Cagney  <cagney@gnu.org>
> 
> 	* gdb.base/signull.c (bowler): Replace data_pointer with data_read
> 	and data_write cases.  Add code_descriptor case.
> 	(zero, desc): New array and pointer.
> 	(data, code): Change to simple pointers.
> 	* gdb.base/signull.exp: Fix probe pattern matching a function
> 	descriptor SIGSEGV.  Replace data_pointer with data_read and
> 	data_write tests.


             reply	other threads:[~2004-06-16 15:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-16 15:39 Michael Elizabeth Chastain [this message]
2004-06-16 16:43 ` Andrew Cagney
  -- strict thread matches above, loose matches on Subject: below --
2004-06-16  5:02 Michael Elizabeth Chastain
2004-06-16 14:54 ` Andrew Cagney
2004-06-16  2:00 Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040616153901.0B93F4B104@berman.michael-chastain.com \
    --to=mec.gnu@mindspring.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox