From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6162 invoked by alias); 16 Jun 2004 15:39:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6144 invoked from network); 16 Jun 2004 15:39:17 -0000 Received: from unknown (HELO mclean.mail.mindspring.net) (207.69.200.57) by sourceware.org with SMTP; 16 Jun 2004 15:39:17 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by mclean.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1BacVO-0006bW-00; Wed, 16 Jun 2004 11:39:14 -0400 Received: by berman.michael-chastain.com (Postfix, from userid 502) id 0B93F4B104; Wed, 16 Jun 2004 11:39:01 -0400 (EDT) To: cagney@gnu.org, mec.gnu@mindspring.com Subject: Re: [rfa/testsuite] Extend signull to work with discriptors Cc: gdb-patches@sources.redhat.com Message-Id: <20040616153901.0B93F4B104@berman.michael-chastain.com> Date: Wed, 16 Jun 2004 15:39:00 -0000 From: mec.gnu@mindspring.com (Michael Elizabeth Chastain) X-SW-Source: 2004-06/txt/msg00374.txt.bz2 > We're going to have to live with this - the testsuite needs to include > deliberately erroneous programs. Yeah, I see what you're saying, and I agree. It's not like the test program is gratuitously non-conforming. You need this 'desc' to do what it's doing in order to test what you're testing. Can you add one more comment? Something like: /* desc is intentionally initialized to a data object. This is needed to test descriptors on arches like ia64. */ It's the old "move the mailing list discussion into a comment" request. With a comment like this, this patch is approved. (And also maybe you have better wording for the comment than I can think of). Michael C > 2004-06-15 Andrew Cagney > > * gdb.base/signull.c (bowler): Replace data_pointer with data_read > and data_write cases. Add code_descriptor case. > (zero, desc): New array and pointer. > (data, code): Change to simple pointers. > * gdb.base/signull.exp: Fix probe pattern matching a function > descriptor SIGSEGV. Replace data_pointer with data_read and > data_write tests.