Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: randolph@tausq.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfa] Use inferior_created observer to cleanup HPUXHPPA code
Date: Mon, 14 Jun 2004 20:25:00 -0000	[thread overview]
Message-ID: <200406142025.i5EKPAvQ000520@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20040614184014.GP19250@tausq.org> (message from Randolph Chung on Mon, 14 Jun 2004 11:40:14 -0700)

   Date: Mon, 14 Jun 2004 11:40:14 -0700
   From: Randolph Chung <randolph@tausq.org>

   ping? -randolph

One minor nit (which is probably just an oversight) -- see below.
With that change this is OK.  Please check it in.

Mark

   > Index: hppa-hpux-tdep.c
   > ===================================================================
   > RCS file: /cvs/src/src/gdb/hppa-hpux-tdep.c,v
   > retrieving revision 1.20
   > diff -u -p -r1.20 hppa-hpux-tdep.c
   > --- hppa-hpux-tdep.c	7 Jun 2004 02:17:29 -0000	1.20
   > +++ hppa-hpux-tdep.c	10 Jun 2004 05:30:40 -0000
   > @@ -30,6 +30,7 @@ Foundation, Inc., 59 Temple Place - Suit
   >  #include "objfiles.h"
   >  #include "inferior.h"
   >  #include "infcall.h"
   > +#include "observer.h"
   >  #include "hppa-tdep.h"
   >  
   >  #include <dl.h>
   > @@ -533,7 +534,7 @@ __eh_notification;
   >  /* Is exception-handling support available with this executable? */
   >  static int hp_cxx_exception_support = 0;
   >  /* Has the initialize function been run? */
   > -int hp_cxx_exception_support_initialized = 0;
   > +static int hp_cxx_exception_support_initialized = 0;
   >  /* Address of __eh_notify_hook */
   >  static CORE_ADDR eh_notify_hook_addr = 0;
   >  /* Address of __d_eh_notify_callback */
   > @@ -1203,6 +1204,15 @@ hppa_hpux_sigtramp_unwind_sniffer (struc
   >    return NULL;
   >  }
   >  
   > +static void
   > +hppa_hpux_inferior_created (struct target_ops *objfile, int from_tty)
   > +{
   > +  /* Some HP-UX related globals to clear when a new "main"
   > +     symbol file is loaded. HP-specific.  */

Please make sure every full stop is followed by two spaces.


  reply	other threads:[~2004-06-14 20:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-10  6:02 Randolph Chung
2004-06-14 18:40 ` Randolph Chung
2004-06-14 20:25   ` Mark Kettenis [this message]
2004-06-14 20:41     ` Randolph Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200406142025.i5EKPAvQ000520@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox