From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8692 invoked by alias); 14 Jun 2004 20:25:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8652 invoked from network); 14 Jun 2004 20:25:16 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 14 Jun 2004 20:25:16 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i5EKPFUu000248; Mon, 14 Jun 2004 22:25:15 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i5EKPF80000523; Mon, 14 Jun 2004 22:25:15 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i5EKPAvQ000520; Mon, 14 Jun 2004 22:25:10 +0200 (CEST) Date: Mon, 14 Jun 2004 20:25:00 -0000 Message-Id: <200406142025.i5EKPAvQ000520@elgar.kettenis.dyndns.org> From: Mark Kettenis To: randolph@tausq.org CC: gdb-patches@sources.redhat.com In-reply-to: <20040614184014.GP19250@tausq.org> (message from Randolph Chung on Mon, 14 Jun 2004 11:40:14 -0700) Subject: Re: [patch/rfa] Use inferior_created observer to cleanup HPUXHPPA code References: <20040610060227.GE561@tausq.org> <20040614184014.GP19250@tausq.org> X-SW-Source: 2004-06/txt/msg00323.txt.bz2 Date: Mon, 14 Jun 2004 11:40:14 -0700 From: Randolph Chung ping? -randolph One minor nit (which is probably just an oversight) -- see below. With that change this is OK. Please check it in. Mark > Index: hppa-hpux-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/hppa-hpux-tdep.c,v > retrieving revision 1.20 > diff -u -p -r1.20 hppa-hpux-tdep.c > --- hppa-hpux-tdep.c 7 Jun 2004 02:17:29 -0000 1.20 > +++ hppa-hpux-tdep.c 10 Jun 2004 05:30:40 -0000 > @@ -30,6 +30,7 @@ Foundation, Inc., 59 Temple Place - Suit > #include "objfiles.h" > #include "inferior.h" > #include "infcall.h" > +#include "observer.h" > #include "hppa-tdep.h" > > #include > @@ -533,7 +534,7 @@ __eh_notification; > /* Is exception-handling support available with this executable? */ > static int hp_cxx_exception_support = 0; > /* Has the initialize function been run? */ > -int hp_cxx_exception_support_initialized = 0; > +static int hp_cxx_exception_support_initialized = 0; > /* Address of __eh_notify_hook */ > static CORE_ADDR eh_notify_hook_addr = 0; > /* Address of __d_eh_notify_callback */ > @@ -1203,6 +1204,15 @@ hppa_hpux_sigtramp_unwind_sniffer (struc > return NULL; > } > > +static void > +hppa_hpux_inferior_created (struct target_ops *objfile, int from_tty) > +{ > + /* Some HP-UX related globals to clear when a new "main" > + symbol file is loaded. HP-specific. */ Please make sure every full stop is followed by two spaces.