Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: cagney@gnu.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Eliminate register_value_being_returned and legacy_return_value
Date: Thu, 10 Jun 2004 21:47:00 -0000	[thread overview]
Message-ID: <200406102147.i5ALlWUm000576@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <40C8CD62.5080902@gnu.org> (message from Andrew Cagney on Thu, 10 Jun 2004 17:06:42 -0400)

   Date: Thu, 10 Jun 2004 17:06:42 -0400
   From: Andrew Cagney <cagney@gnu.org>

   Hello,

   This patch eliminates calls to both register_value_being_returned and 
   legacy_return_value by inlining / simplifying the callers.  Turns out 
   there was much duplication of effort with both the caller and callees 
   all performing the same tasks.

This patch gives me a bad feeling.  I had intentionally introduced
legacy_return_value to isolate all the legacy code in a single
function.  Yes, that duplicates some of the code, but I think it makes
the code much, much easier to understand.  It also makes removing the
legacy code much more easier later on.

Mark


  reply	other threads:[~2004-06-10 21:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-10 21:06 Andrew Cagney
2004-06-10 21:47 ` Mark Kettenis [this message]
2004-06-10 22:03   ` Andrew Cagney
2004-06-12 18:04     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200406102147.i5ALlWUm000576@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox