From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18202 invoked by alias); 10 Jun 2004 21:47:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18189 invoked from network); 10 Jun 2004 21:47:35 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 10 Jun 2004 21:47:35 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i5ALlWLO000474; Thu, 10 Jun 2004 23:47:32 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i5ALlWqA000579; Thu, 10 Jun 2004 23:47:32 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i5ALlWUm000576; Thu, 10 Jun 2004 23:47:32 +0200 (CEST) Date: Thu, 10 Jun 2004 21:47:00 -0000 Message-Id: <200406102147.i5ALlWUm000576@elgar.kettenis.dyndns.org> From: Mark Kettenis To: cagney@gnu.org CC: gdb-patches@sources.redhat.com In-reply-to: <40C8CD62.5080902@gnu.org> (message from Andrew Cagney on Thu, 10 Jun 2004 17:06:42 -0400) Subject: Re: [patch/rfc] Eliminate register_value_being_returned and legacy_return_value References: <40C8CD62.5080902@gnu.org> X-SW-Source: 2004-06/txt/msg00245.txt.bz2 Date: Thu, 10 Jun 2004 17:06:42 -0400 From: Andrew Cagney Hello, This patch eliminates calls to both register_value_being_returned and legacy_return_value by inlining / simplifying the callers. Turns out there was much duplication of effort with both the caller and callees all performing the same tasks. This patch gives me a bad feeling. I had intentionally introduced legacy_return_value to isolate all the legacy code in a single function. Yes, that duplicates some of the code, but I think it makes the code much, much easier to understand. It also makes removing the legacy code much more easier later on. Mark