From: Kevin Buettner <kevinb@redhat.com>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: fix assertions; handle endianness more directly
Date: Fri, 04 Jun 2004 22:39:00 -0000 [thread overview]
Message-ID: <20040604153934.46fb178e@saguaro> (raw)
In-Reply-To: <vt24qpsxsg1.fsf@zenia.home>
On 03 Jun 2004 16:06:06 -0500
Jim Blandy <jimb@redhat.com> wrote:
> 2004-06-02 Jim Blandy <jimb@redhat.com>
>
> * ppc-linux-nat.c (store_register, fetch_register): Remove
> incorrect assertions. Simplify and generalize handling of
> transfers whose sizes are not multiples of, or less than, sizeof
> (PTRACE_XFER_TYPE).
Okay, except for:
> ! for (bytes_transferred = 0;
> ! bytes_transferred < DEPRECATED_REGISTER_RAW_SIZE (regno);
> ! bytes_transferred += sizeof (PTRACE_XFER_TYPE))
Please use register_size() here instead of DEPRECATED_REGISTER_RAW_SIZE().
(I notice that you made this substitution elsewhere.)
Kevin
next prev parent reply other threads:[~2004-06-04 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-03 21:07 Jim Blandy
2004-06-04 22:39 ` Kevin Buettner [this message]
2004-06-04 23:10 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040604153934.46fb178e@saguaro \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox