From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-33594-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 23300 invoked by alias); 4 Jun 2004 22:39:44 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 23285 invoked from network); 4 Jun 2004 22:39:41 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 4 Jun 2004 22:39:41 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i54Mdfi5028356
	for <gdb-patches@sources.redhat.com>; Fri, 4 Jun 2004 18:39:41 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i54Mde022461
	for <gdb-patches@sources.redhat.com>; Fri, 4 Jun 2004 18:39:40 -0400
Received: from localhost.localdomain (vpn50-15.rdu.redhat.com [172.16.50.15])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id i54MdeNV028121;
	Fri, 4 Jun 2004 18:39:40 -0400
Received: from saguaro (saguaro.lan [192.168.64.2])
	by localhost.localdomain (8.12.11/8.12.10) with SMTP id i54MdYHX026902;
	Fri, 4 Jun 2004 15:39:34 -0700
Date: Fri, 04 Jun 2004 22:39:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: fix assertions; handle endianness more directly
Message-Id: <20040604153934.46fb178e@saguaro>
In-Reply-To: <vt24qpsxsg1.fsf@zenia.home>
References: <vt24qpsxsg1.fsf@zenia.home>
Organization: Red Hat
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-06/txt/msg00086.txt.bz2

On 03 Jun 2004 16:06:06 -0500
Jim Blandy <jimb@redhat.com> wrote:

> 2004-06-02  Jim Blandy  <jimb@redhat.com>
> 
> 	* ppc-linux-nat.c (store_register, fetch_register): Remove
> 	incorrect assertions.  Simplify and generalize handling of
> 	transfers whose sizes are not multiples of, or less than, sizeof
> 	(PTRACE_XFER_TYPE).

Okay, except for:

> !   for (bytes_transferred = 0;
> !        bytes_transferred < DEPRECATED_REGISTER_RAW_SIZE (regno);
> !        bytes_transferred += sizeof (PTRACE_XFER_TYPE))

Please use register_size() here instead of DEPRECATED_REGISTER_RAW_SIZE().
(I notice that you made this substitution elsewhere.)

Kevin