Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix signull test case
Date: Thu, 20 May 2004 14:05:00 -0000	[thread overview]
Message-ID: <20040520140500.GA12221@nevyn.them.org> (raw)
In-Reply-To: <200405201330.PAA24916@faui1d.informatik.uni-erlangen.de>

On Thu, May 20, 2004 at 03:30:51PM +0200, Ulrich Weigand wrote:
> Hello,
> 
> the signull.exp test case fails when running under a 2.6 kernel,
> because it uses longjmp to leave a SIGSEGV handler.  This results
> in the signal remaining blocked for the rest of program execution,
> and the second segmentation violation triggered by the test case
> simply terminates the program.  The fix is to use siglongjmp.
> 
> Also, the test case uses 'signal' to install the signal handler;
> according to POSIX it is undefined whether this routine installs
> the handler with the 'one-shot' property or not.  (Apparently,
> on BSD-like systems 'one-shot' is the default.)
> 
> Thus, I've also changed the test case to use sigaction instead,
> to make sure the handler remains active across multiple invocations.
> (This isn't currently an actual problem on Linux systems -- if you
> prefer I can remove this part.)
> 
> Tested on s390-ibm-linux and s390x-ibm-linux, fixes one test suite
> failure.
> 
> OK?

There's a typo in your changelog entry: gdb.bas/.  Otherwise this is OK
- thank you very much!  Fixes two failures on i386-pc-linux-gnu.

-- 
Daniel Jacobowitz


  reply	other threads:[~2004-05-20 14:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-20 13:30 Ulrich Weigand
2004-05-20 14:05 ` Daniel Jacobowitz [this message]
2004-05-21 17:10 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040520140500.GA12221@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=weigand@i1.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox