From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix signull test case Date: Thu, 20 May 2004 14:05:00 -0000 Message-id: <20040520140500.GA12221@nevyn.them.org> References: <200405201330.PAA24916@faui1d.informatik.uni-erlangen.de> X-SW-Source: 2004-05/msg00608.html On Thu, May 20, 2004 at 03:30:51PM +0200, Ulrich Weigand wrote: > Hello, > > the signull.exp test case fails when running under a 2.6 kernel, > because it uses longjmp to leave a SIGSEGV handler. This results > in the signal remaining blocked for the rest of program execution, > and the second segmentation violation triggered by the test case > simply terminates the program. The fix is to use siglongjmp. > > Also, the test case uses 'signal' to install the signal handler; > according to POSIX it is undefined whether this routine installs > the handler with the 'one-shot' property or not. (Apparently, > on BSD-like systems 'one-shot' is the default.) > > Thus, I've also changed the test case to use sigaction instead, > to make sure the handler remains active across multiple invocations. > (This isn't currently an actual problem on Linux systems -- if you > prefer I can remove this part.) > > Tested on s390-ibm-linux and s390x-ibm-linux, fixes one test suite > failure. > > OK? There's a typo in your changelog entry: gdb.bas/. Otherwise this is OK - thank you very much! Fixes two failures on i386-pc-linux-gnu. -- Daniel Jacobowitz