Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version)
@ 2004-05-18 21:23 Joel Brobecker
  2004-05-18 21:56 ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion) Michael Snyder
  2004-05-18 21:57 ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
  0 siblings, 2 replies; 7+ messages in thread
From: Joel Brobecker @ 2004-05-18 21:23 UTC (permalink / raw)
  To: gdb-patches

Hello,

Michael had a very clever idea on how to avoid the assumption that
the block thread is the thread with the highest ID. We just get a
backtrace from all threads, and check that one of them matches the
backtrace that would be expected from the thread that would be blocked.

2004-05-18  J. Brobecker  <brobecker@gnat.com>

        * gdb.threads/pt.c: New file.
        * gdb.threads/pthread_cond_wait.exp: New test.

OK to apply?

Thanks,
-- 
Joel


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion)
  2004-05-18 21:23 [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
@ 2004-05-18 21:56 ` Michael Snyder
  2004-05-18 21:59   ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
  2004-05-18 22:06   ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion) Michael Snyder
  2004-05-18 21:57 ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
  1 sibling, 2 replies; 7+ messages in thread
From: Michael Snyder @ 2004-05-18 21:56 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

Joel Brobecker wrote:
Hello,

Michael had a very clever idea on how to avoid the assumption that
the block thread is the thread with the highest ID. We just get a
backtrace from all threads, and check that one of them matches the
backtrace that would be expected from the thread that would be blocked.
2004-05-18  J. Brobecker  <brobecker@gnat.com>

        * gdb.threads/pt.c: New file.
        * gdb.threads/pthread_cond_wait.exp: New test.
OK to apply?
Oh, and you were gonna change the name of the source file.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version)
  2004-05-18 21:23 [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
  2004-05-18 21:56 ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion) Michael Snyder
@ 2004-05-18 21:57 ` Joel Brobecker
  2004-05-18 22:03   ` Daniel Jacobowitz
  1 sibling, 1 reply; 7+ messages in thread
From: Joel Brobecker @ 2004-05-18 21:57 UTC (permalink / raw)
  To: gdb-patches

[sigh, with the patch this time...]

Michael had a very clever idea on how to avoid the assumption that
the block thread is the thread with the highest ID. We just get a
backtrace from all threads, and check that one of them matches the
backtrace that would be expected from the thread that would be blocked.

2004-05-18  J. Brobecker  <brobecker@gnat.com>

        * gdb.threads/pt.c: New file.
        * gdb.threads/pthread_cond_wait.exp: New test.

OK to apply?

-- 
Joel
Attachment:
pthread_cond_wait.c
Description: Text document
Attachment:
pthread_cond_wait.exp
Description: Text document


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version)
  2004-05-18 21:56 ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion) Michael Snyder
@ 2004-05-18 21:59   ` Joel Brobecker
  2004-05-18 22:06   ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion) Michael Snyder
  1 sibling, 0 replies; 7+ messages in thread
From: Joel Brobecker @ 2004-05-18 21:59 UTC (permalink / raw)
  To: Michael Snyder; +Cc: gdb-patches

> >2004-05-18  J. Brobecker  <brobecker@gnat.com>
> >
> >        * gdb.threads/pt.c: New file.
> >        * gdb.threads/pthread_cond_wait.exp: New test.
> >
> >OK to apply?
> 
> Oh, and you were gonna change the name of the source file.

Aaahhhh, yes, I forgot to update the ChangeLog but I confirm the name
has changed to pthread_cond_wait.c.

Thanks for spotting this.
-- 
Joel


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version)
  2004-05-18 21:57 ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
@ 2004-05-18 22:03   ` Daniel Jacobowitz
  2004-05-18 22:05     ` Joel Brobecker
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Jacobowitz @ 2004-05-18 22:03 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

On Tue, May 18, 2004 at 02:57:30PM -0700, Joel Brobecker wrote:
> /* A small multi-threaded test case.
> 
>    Copyright 2003

Welcome to the present :)  Even though this was posted in 2003
originally, it was not released, so it should just say 2004.


-- 
Daniel Jacobowitz


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version)
  2004-05-18 22:03   ` Daniel Jacobowitz
@ 2004-05-18 22:05     ` Joel Brobecker
  0 siblings, 0 replies; 7+ messages in thread
From: Joel Brobecker @ 2004-05-18 22:05 UTC (permalink / raw)
  To: gdb-patches

> > /* A small multi-threaded test case.
> > 
> >    Copyright 2003
> 
> Welcome to the present :)  Even though this was posted in 2003
> originally, it was not released, so it should just say 2004.

I think I'm never going to get this one right. Let me finish what I am
doing right now, take an aspirin, and resubmit everything properly.

:-)

-- 
Joel


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion)
  2004-05-18 21:56 ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion) Michael Snyder
  2004-05-18 21:59   ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
@ 2004-05-18 22:06   ` Michael Snyder
  1 sibling, 0 replies; 7+ messages in thread
From: Michael Snyder @ 2004-05-18 22:06 UTC (permalink / raw)
  To: Michael Snyder; +Cc: Joel Brobecker, gdb-patches

Michael Snyder wrote:
Joel Brobecker wrote:

Hello,

Michael had a very clever idea on how to avoid the assumption that
the block thread is the thread with the highest ID. We just get a
backtrace from all threads, and check that one of them matches the
backtrace that would be expected from the thread that would be blocked.
2004-05-18  J. Brobecker  <brobecker@gnat.com>

        * gdb.threads/pt.c: New file.
        * gdb.threads/pthread_cond_wait.exp: New test.
OK to apply?


Oh, and you were gonna change the name of the source file.
Oops, sorry, that was meant to be a private reply.




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2004-05-18 22:06 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-18 21:23 [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
2004-05-18 21:56 ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion) Michael Snyder
2004-05-18 21:59   ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
2004-05-18 22:06   ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2ndversion) Michael Snyder
2004-05-18 21:57 ` [RFA/testsuite/threads] backtrace past pthread_cond_wait() (2nd version) Joel Brobecker
2004-05-18 22:03   ` Daniel Jacobowitz
2004-05-18 22:05     ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox