Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [RFA] Make QUIT work
Date: Sat, 08 May 2004 04:51:00 -0000	[thread overview]
Message-ID: <20040508045116.GA5860@nevyn.them.org> (raw)
In-Reply-To: <409C5394.3070208@redhat.com>

On Sat, May 08, 2004 at 03:27:16AM +0000, Michael Snyder wrote:
> Elena, here's something that must have fallen thru the cracks
> at some point.  handle_sigint needs to set quit_flag -- or else
> QUIT won't quit.  As is currently, QUIT won't work unles
> immediate_quit is set -- and I'm pretty sure that's not how
> it was intended to work.
> 

See the patch Joel submitted for this last August.  Elena deferred it
to after 6.1 because just setting quit_flag invokes both sets of event
handling machinery, potentially quitting twice.

> 2004-05-08  Michael Snyder  <msnyder@redhat.com>
> 
> 	* event-top.c (handle_sigint): Set quit_flag, so that QUIT
> 	will work the next time it's invoked.
> 
> Index: event-top.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/event-top.c,v
> retrieving revision 1.33
> diff -p -r1.33 event-top.c
> *** event-top.c	28 Feb 2004 18:04:36 -0000	1.33
> --- event-top.c	8 May 2004 03:22:55 -0000
> *************** void
> *** 950,955 ****
> --- 950,956 ----
>   handle_sigint (int sig)
>   {
>     signal (sig, handle_sigint);
> +   quit_flag=1;
>   
>     /* If immediate_quit is set, we go ahead and process the SIGINT right
>        away, even if we usually would defer this to the event loop. The


-- 
Daniel Jacobowitz


  reply	other threads:[~2004-05-08  4:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-08  3:27 Michael Snyder
2004-05-08  4:51 ` Daniel Jacobowitz [this message]
2004-05-08  6:16   ` Joel Brobecker
2004-05-10 23:07     ` Michael Snyder
2004-05-10 23:09       ` Joel Brobecker
2004-05-11  1:11   ` Andrew Cagney
2004-05-11  1:38     ` Michael Snyder
2004-05-11  2:19       ` Daniel Jacobowitz
2004-05-11 15:07       ` Andrew Cagney
2004-05-11 18:37         ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040508045116.GA5860@nevyn.them.org \
    --to=drow@false.org \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox