From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26889 invoked by alias); 8 May 2004 04:51:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26867 invoked from network); 8 May 2004 04:51:16 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 8 May 2004 04:51:16 -0000 Received: from drow by nevyn.them.org with local (Exim 4.32 #1 (Debian)) id 1BMJnw-0001Ww-5R; Sat, 08 May 2004 00:51:16 -0400 Date: Sat, 08 May 2004 04:51:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sources.redhat.com, Elena Zannoni Subject: Re: [RFA] Make QUIT work Message-ID: <20040508045116.GA5860@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sources.redhat.com, Elena Zannoni References: <409C5394.3070208@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <409C5394.3070208@redhat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-05/txt/msg00238.txt.bz2 On Sat, May 08, 2004 at 03:27:16AM +0000, Michael Snyder wrote: > Elena, here's something that must have fallen thru the cracks > at some point. handle_sigint needs to set quit_flag -- or else > QUIT won't quit. As is currently, QUIT won't work unles > immediate_quit is set -- and I'm pretty sure that's not how > it was intended to work. > See the patch Joel submitted for this last August. Elena deferred it to after 6.1 because just setting quit_flag invokes both sets of event handling machinery, potentially quitting twice. > 2004-05-08 Michael Snyder > > * event-top.c (handle_sigint): Set quit_flag, so that QUIT > will work the next time it's invoked. > > Index: event-top.c > =================================================================== > RCS file: /cvs/src/src/gdb/event-top.c,v > retrieving revision 1.33 > diff -p -r1.33 event-top.c > *** event-top.c 28 Feb 2004 18:04:36 -0000 1.33 > --- event-top.c 8 May 2004 03:22:55 -0000 > *************** void > *** 950,955 **** > --- 950,956 ---- > handle_sigint (int sig) > { > signal (sig, handle_sigint); > + quit_flag=1; > > /* If immediate_quit is set, we go ahead and process the SIGINT right > away, even if we usually would defer this to the event loop. The -- Daniel Jacobowitz