Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@redhat.com>
Cc: cagney <cagney@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Prevent runaway (infinite loop) in mips-tdep.c
Date: Wed, 21 Apr 2004 00:53:00 -0000	[thread overview]
Message-ID: <20040421005257.GA11993@nevyn.them.org> (raw)
In-Reply-To: <4085BE65.3000402@redhat.com>

On Wed, Apr 21, 2004 at 12:20:53AM +0000, Michael Snyder wrote:
> Hi Andrew,
> 
> This change will prevent the caller(s) of mips_mdebug_frame_id from
> infinite-looping when we get badly lost on the stack frame.
> 

> 2004-04-21  Michael Snyder  <msnyder@redhat.com>
> 
> 	* mips-tdep.c (mips_mdebug_frame_cache): Call error to prevent
> 	infinite looping by caller.
> 	(heuristic_proc_start): Warning() already prefixes "Warning: ".

Since I have some patches to make this "I'm not sure how" case into a
working part of the unwinder, I don't much like this.  They got hung up
on the question of how to trust proc_desc's when we might be in the
prologue.

One time where this case occurs is in backtracing from a NULL pointer
dereference, which happens in the GDB testsuite now.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-04-21  0:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-21  0:20 Michael Snyder
2004-04-21  0:53 ` Daniel Jacobowitz [this message]
2004-04-21 17:58   ` Michael Snyder
2004-04-21 19:18     ` Daniel Jacobowitz
2004-04-21 19:23     ` Andrew Cagney
2004-04-22 21:11       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040421005257.GA11993@nevyn.them.org \
    --to=drow@false.org \
    --cc=cagney@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox