From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12714 invoked by alias); 21 Apr 2004 00:53:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12378 invoked from network); 21 Apr 2004 00:52:58 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 21 Apr 2004 00:52:58 -0000 Received: from drow by nevyn.them.org with local (Exim 4.32 #1 (Debian)) id 1BG5yz-0003Lg-VA; Tue, 20 Apr 2004 20:52:58 -0400 Date: Wed, 21 Apr 2004 00:53:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: cagney , gdb-patches@sources.redhat.com Subject: Re: [RFA] Prevent runaway (infinite loop) in mips-tdep.c Message-ID: <20040421005257.GA11993@nevyn.them.org> Mail-Followup-To: Michael Snyder , cagney , gdb-patches@sources.redhat.com References: <4085BE65.3000402@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4085BE65.3000402@redhat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-04/txt/msg00476.txt.bz2 On Wed, Apr 21, 2004 at 12:20:53AM +0000, Michael Snyder wrote: > Hi Andrew, > > This change will prevent the caller(s) of mips_mdebug_frame_id from > infinite-looping when we get badly lost on the stack frame. > > 2004-04-21 Michael Snyder > > * mips-tdep.c (mips_mdebug_frame_cache): Call error to prevent > infinite looping by caller. > (heuristic_proc_start): Warning() already prefixes "Warning: ". Since I have some patches to make this "I'm not sure how" case into a working part of the unwinder, I don't much like this. They got hung up on the question of how to trust proc_desc's when we might be in the prologue. One time where this case occurs is in backtracing from a NULL pointer dereference, which happens in the GDB testsuite now. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer