From: Randolph Chung <randolph@tausq.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/resend/rfa] (2/4) Cleanup tm-hppa.h for multiarch.
Date: Thu, 15 Apr 2004 16:37:00 -0000 [thread overview]
Message-ID: <20040415165325.GF23831@tausq.org> (raw)
In-Reply-To: <407EB811.3060708@gnu.org>
In reference to a message from Andrew Cagney, dated Apr 15:
> >2004-04-13 Randolph Chung <tausq@debian.org>
> >
> > * hppa-tdep.h (INSTRUCTION_SIZE): Move from tm-hppa.h.
> > * config/pa/tm-hppa.h (INSTRUCTION_SIZE): Move to hppa-tdep.c.
>
> It should be renamed to HPPA_INSTRUCTION_SIZE and might as well declare
> it as:
> enum { HPPA_INSTRUCTION_SIZE = 4 };
> Also does the new PA GNU/Linux file use INSTRUCTION_SIZE? If it
> doesn't, the definition might as well live in hppa-tdep.c
right now the linux file doesn't do very much, no references to
instruction size yet. I'm not quite sure there's a lot of value in using
a enum/#define vs just inlining it and putting e.g. 4*x
> After that (remember to update hppa-tdep.c's references) ok,
thanks.
randolph
--
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
next prev parent reply other threads:[~2004-04-15 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 6:24 Randolph Chung
2004-04-15 16:22 ` Andrew Cagney
2004-04-17 17:21 ` Randolph Chung
2004-04-15 16:28 ` Andrew Cagney
2004-04-15 16:37 ` Randolph Chung [this message]
2004-04-15 17:16 ` Andrew Cagney
2004-04-15 17:26 ` Randolph Chung
2004-04-15 18:45 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040415165325.GF23831@tausq.org \
--to=randolph@tausq.org \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox