From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10505 invoked by alias); 15 Apr 2004 16:37:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10496 invoked from network); 15 Apr 2004 16:37:45 -0000 Received: from unknown (HELO pippin.tausq.org) (64.81.244.94) by sources.redhat.com with SMTP; 15 Apr 2004 16:37:45 -0000 Received: by pippin.tausq.org (Postfix, from userid 1000) id BEF65CD29F; Thu, 15 Apr 2004 09:53:25 -0700 (PDT) Date: Thu, 15 Apr 2004 16:37:00 -0000 From: Randolph Chung To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/resend/rfa] (2/4) Cleanup tm-hppa.h for multiarch. Message-ID: <20040415165325.GF23831@tausq.org> Reply-To: Randolph Chung References: <20040414062442.GK31873@tausq.org> <407EB811.3060708@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <407EB811.3060708@gnu.org> X-GPG: for GPG key, see http://www.tausq.org/gpg.txt User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-04/txt/msg00317.txt.bz2 In reference to a message from Andrew Cagney, dated Apr 15: > >2004-04-13 Randolph Chung > > > > * hppa-tdep.h (INSTRUCTION_SIZE): Move from tm-hppa.h. > > * config/pa/tm-hppa.h (INSTRUCTION_SIZE): Move to hppa-tdep.c. > > It should be renamed to HPPA_INSTRUCTION_SIZE and might as well declare > it as: > enum { HPPA_INSTRUCTION_SIZE = 4 }; > Also does the new PA GNU/Linux file use INSTRUCTION_SIZE? If it > doesn't, the definition might as well live in hppa-tdep.c right now the linux file doesn't do very much, no references to instruction size yet. I'm not quite sure there's a lot of value in using a enum/#define vs just inlining it and putting e.g. 4*x > After that (remember to update hppa-tdep.c's references) ok, thanks. randolph -- Randolph Chung Debian GNU/Linux Developer, hppa/ia64 ports http://www.tausq.org/