[patch] hppa cleanup 2

[patch] hppa cleanup 2

[Randolph Chung]

2004-04-07  Randolph Chung  <tausq@debian.org>

	* hppa-tdep.c (hppa_inner_than): Remove.
	(is_pa_2): Remove unused static variable.
	(hppa_gdbarch_init): Use core_addr_greaterthan instead of own version. 

--- gdb-work/gdb/hppa-tdep.c.orig	2004-04-07 23:51:28.565648936 -0700
+++ gdb-work/gdb/hppa-tdep.c	2004-04-07 23:50:37.923347736 -0700
@@ -138,7 +138,6 @@
 CORE_ADDR hppa_skip_trampoline_code (CORE_ADDR pc);
 int hppa_in_solib_call_trampoline (CORE_ADDR pc, char *name);
 int hppa_in_solib_return_trampoline (CORE_ADDR pc, char *name);
-int hppa_inner_than (CORE_ADDR lhs, CORE_ADDR rhs);
 int hppa_pc_requires_run_before_use (CORE_ADDR pc);
 int hppa_instruction_nullified (void);
 int hppa_cannot_store_register (int regnum);
@@ -146,8 +145,6 @@
 CORE_ADDR hppa_target_read_pc (ptid_t ptid);
 void hppa_target_write_pc (CORE_ADDR v, ptid_t ptid);
 
-static int is_pa_2 = 0;		/* False */
-
 /* Handle 32/64-bit struct return conventions.  */
 
 static enum return_value_convention
@@ -2462,13 +2459,6 @@
 }
 
 int
-hppa_inner_than (CORE_ADDR lhs, CORE_ADDR rhs)
-{
-  /* Stack grows upward */
-  return (lhs > rhs);
-}
-
-int
 hppa_pc_requires_run_before_use (CORE_ADDR pc)
 {
   /* Sometimes we may pluck out a minimal symbol that has a negative address.
@@ -2679,7 +2669,7 @@
   set_gdbarch_in_solib_call_trampoline (gdbarch, hppa_in_solib_call_trampoline);
   set_gdbarch_in_solib_return_trampoline (gdbarch,
                                           hppa_in_solib_return_trampoline);
-  set_gdbarch_inner_than (gdbarch, hppa_inner_than);
+  set_gdbarch_inner_than (gdbarch, core_addr_greaterthan);
   set_gdbarch_sp_regnum (gdbarch, HPPA_SP_REGNUM);
   set_gdbarch_fp0_regnum (gdbarch, HPPA_FP0_REGNUM);
   set_gdbarch_cannot_store_register (gdbarch, hppa_cannot_store_register);
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/

Re: [patch] hppa cleanup 2

[Daniel Jacobowitz]

On Thu, Apr 08, 2004 at 12:12:26AM -0700, Randolph Chung wrote:
> 2004-04-07  Randolph Chung  <tausq@debian.org>
> 
> 	* hppa-tdep.c (hppa_inner_than): Remove.
> 	(is_pa_2): Remove unused static variable.
> 	(hppa_gdbarch_init): Use core_addr_greaterthan instead of own version. 

This is OK.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer