Re: [RFA/testsuite/ada] Do not abort prematurely the test upon build failure

[Daniel Jacobowitz <drow@false.org>]

On Wed, Mar 31, 2004 at 10:18:28PM -0800, Joel Brobecker wrote:
> > Unfortunately you didn't pick the best example... please do something
> > like issuing one UNSUPPORTED and then returning. 
> > gdb_suppress_entire_file is evil.
> 
> I knew it! :-) (there's something evil, and sure enough I pick it)
> 
> UNSUPPORTED sounds better indeed. Thanks for the suggestion.
> 
> I'd like to put the call to unsupported inside gdb_compile_ada in order
> to help having a certain consistency between all Ada testcases. So I'd
> like to suggest the attached patch instead. The code in null_record.exp
> can thus remain the same (simply abort if gdb_compile_ada returns a
> failure, nothing else to do since the unsupported has already been
> emitted).
> 
> 2004-03-31  Joel Brobecker  <brobecker@gnat.com>
> 
>         * lib/ada.exp (gdb_compile_ada): Emit UNSUPPORTED if we failed
>         to build the application. Remove the message printed when in
>         verbose mode, redundant with the UNSUPPORTED message above.
> 
> (not sure if I used the proper terminology in the ChangeLog entry)

This patch is OK.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer