From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1739 invoked by alias); 1 Apr 2004 15:08:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1719 invoked from network); 1 Apr 2004 15:08:26 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 1 Apr 2004 15:08:26 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B93ny-00088F-Em; Thu, 01 Apr 2004 10:08:30 -0500 Date: Thu, 01 Apr 2004 15:08:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite/ada] Do not abort prematurely the test upon build failure Message-ID: <20040401150830.GB31170@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20040401023006.GL888@gnat.com> <20040401040241.GA14882@nevyn.them.org> <20040401061828.GN888@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040401061828.GN888@gnat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-04/txt/msg00022.txt.bz2 On Wed, Mar 31, 2004 at 10:18:28PM -0800, Joel Brobecker wrote: > > Unfortunately you didn't pick the best example... please do something > > like issuing one UNSUPPORTED and then returning. > > gdb_suppress_entire_file is evil. > > I knew it! :-) (there's something evil, and sure enough I pick it) > > UNSUPPORTED sounds better indeed. Thanks for the suggestion. > > I'd like to put the call to unsupported inside gdb_compile_ada in order > to help having a certain consistency between all Ada testcases. So I'd > like to suggest the attached patch instead. The code in null_record.exp > can thus remain the same (simply abort if gdb_compile_ada returns a > failure, nothing else to do since the unsupported has already been > emitted). > > 2004-03-31 Joel Brobecker > > * lib/ada.exp (gdb_compile_ada): Emit UNSUPPORTED if we failed > to build the application. Remove the message printed when in > verbose mode, redundant with the UNSUPPORTED message above. > > (not sure if I used the proper terminology in the ChangeLog entry) This patch is OK. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer