Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/mips] Fix reread.exp on mips-linux
Date: Mon, 29 Mar 2004 18:02:00 -0000	[thread overview]
Message-ID: <20040329180203.GA20805@nevyn.them.org> (raw)
In-Reply-To: <406753AE.6090401@gnu.org>

On Sun, Mar 28, 2004 at 05:37:34PM -0500, Andrew Cagney wrote:
> >My goof, from two years or so ago.  This is allocated on the objfile
> >obstack, and we stashed it in obj_private; but obj_private doesn't get
> >cleared.  If we put it in the new objfile_data machinery like a good little
> >interface user, then it gets cleared at the right time.  This prevents
> >segfaulting as soon as the executable changes.
> >
> >OK for head/6.1?
> 
> Ok for mainline.  For the moment sit on it for the branch.

Committed both, with your later approval for the branch.  Thanks.

> >-      priv = (struct mips_objfile_private *) sec->objfile->obj_private;
> can something from this be ARIed?

Any reference to obj_private, I think.  This was the last one outside
of HPPA/HPUX code:
  	
drow@nevyn:/opt/src/gdb/src/gdb% grep -lr obj_private .
./hppa-tdep.c
./hpread.c
./pa64solib.c
./somread.c
./somsolib.c
./config/pa/tm-hppa.h

[And some changelogs, and the definition in objfiles.h]

If someone wants to fix that, we can then remove obj_private entirely.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


      reply	other threads:[~2004-03-29 18:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-25  1:53 Daniel Jacobowitz
2004-03-28 22:37 ` Andrew Cagney
2004-03-29 18:02   ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040329180203.GA20805@nevyn.them.org \
    --to=drow@false.org \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox