From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9151 invoked by alias); 29 Mar 2004 18:02:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9080 invoked from network); 29 Mar 2004 18:02:04 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 29 Mar 2004 18:02:04 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B815I-0005Uw-57; Mon, 29 Mar 2004 13:02:04 -0500 Date: Mon, 29 Mar 2004 18:02:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/mips] Fix reread.exp on mips-linux Message-ID: <20040329180203.GA20805@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com References: <20040325015317.GA10143@nevyn.them.org> <406753AE.6090401@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <406753AE.6090401@gnu.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03/txt/msg00721.txt.bz2 On Sun, Mar 28, 2004 at 05:37:34PM -0500, Andrew Cagney wrote: > >My goof, from two years or so ago. This is allocated on the objfile > >obstack, and we stashed it in obj_private; but obj_private doesn't get > >cleared. If we put it in the new objfile_data machinery like a good little > >interface user, then it gets cleared at the right time. This prevents > >segfaulting as soon as the executable changes. > > > >OK for head/6.1? > > Ok for mainline. For the moment sit on it for the branch. Committed both, with your later approval for the branch. Thanks. > >- priv = (struct mips_objfile_private *) sec->objfile->obj_private; > can something from this be ARIed? Any reference to obj_private, I think. This was the last one outside of HPPA/HPUX code: drow@nevyn:/opt/src/gdb/src/gdb% grep -lr obj_private . ./hppa-tdep.c ./hpread.c ./pa64solib.c ./somread.c ./somsolib.c ./config/pa/tm-hppa.h [And some changelogs, and the definition in objfiles.h] If someone wants to fix that, we can then remove obj_private entirely. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer